fix: properly sanitize npm_config_registry env-var @W-22606077#1266
Merged
Conversation
jfeingold35
force-pushed
the
d/W-22606077
branch
from
18f84f5 to
2e340b3
Compare
iowillhoit
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Properly sanitizes the registry url to make sure that it's a well-formed and non-malicious URL, thereby preventing command injection or other malicious jiggerypokery.
Replaced
shelljs.exec()(which interprets shell metacharacters) withcross-spawn.sync()(which passes arguments as an array without shell interpretation). Preventing attacker-controlled package names from escaping into shell command execution.What issues does this PR fix or reference?
@W-22606077@
@W-22561395@