Skip to content

@W-22796074 qa#17

Merged
iowillhoit merged 5 commits into
mainfrom
ew/qa
Jun 9, 2026
Merged

@W-22796074 qa#17
iowillhoit merged 5 commits into
mainfrom
ew/qa

Conversation

@iowillhoit

Copy link
Copy Markdown
Contributor

Summary

  • Replace raw fetch() with sourceConnection.request() for the export API call, matching how the import already works
  • Fixes build failure: ESLint couldn't resolve types for global fetch with @typescript-eslint@6
  • Updates TypeScript from ^6.0.3 to ^5.9.3 (compatible with @salesforce/dev-scripts@11)

fetch to conn.request changes:

  • Passed as { timeout: SetupTransfer.HTTP_TIMEOUT_MS } in the options argument. Jsforce's HttpRequestOptions supports this natively.
  • Sanitization is no longer needed. connection.request() parses the JSON response internally via jsforce's parseResponseBody. The control-character
    stripping was a defensive workaround for raw fetch().text(). Jsforce handles malformed responses by falling back to the raw body string.
  • HJsforce throws on non-2xx status codes and handles 401s with automatic token refresh.

Test plan

  • yarn build passes
  • yarn test:only passes (9 tests)
  • Verify against real orgs with --definition-identifier mode
  • Verify against real orgs with --extended-definition-file mode

@W-22796074@

@git2gus

git2gus Bot commented Jun 2, 2026

Copy link
Copy Markdown

Git2Gus App is installed but the .git2gus/config.json doesn't exist.

@iowillhoit

Copy link
Copy Markdown
Contributor Author

@johnchenlive you need to add a .git2gus/config.json file. Here is an example https://github.com/salesforcecli/plugin-org/blob/main/.git2gus/config.json

You should also add some NUT (integration) test to confirm this is working as expected across two orgs. https://developer.salesforce.com/docs/platform/salesforce-cli-plugin/guide/test-plugin.html#non-unit-tests

@johnchenlive

Copy link
Copy Markdown
Collaborator

@johnchenlive you need to add a .git2gus/config.json file. Here is an example https://github.com/salesforcecli/plugin-org/blob/main/.git2gus/config.json

You should also add some NUT (integration) test to confirm this is working as expected across two orgs. https://developer.salesforce.com/docs/platform/salesforce-cli-plugin/guide/test-plugin.html#non-unit-tests

will do

Comment thread package.json
"oclif": "^4.23.8",
"ts-node": "^10.9.2",
"typescript": "^6.0.3",
"wireit": "^0.14.12"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iowillhoit wireit is removed here, but still referenced in other places in package.json. So shall we remove all references of wireit?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of dev-deps are automatically pulled in via dev-scripts, wireit is one of them

@iowillhoit iowillhoit merged commit fb529dd into main Jun 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants