@W-22796074 qa#17
Conversation
|
Git2Gus App is installed but the |
|
@johnchenlive you need to add a You should also add some NUT (integration) test to confirm this is working as expected across two orgs. https://developer.salesforce.com/docs/platform/salesforce-cli-plugin/guide/test-plugin.html#non-unit-tests |
will do |
| "oclif": "^4.23.8", | ||
| "ts-node": "^10.9.2", | ||
| "typescript": "^6.0.3", | ||
| "wireit": "^0.14.12" |
There was a problem hiding this comment.
@iowillhoit wireit is removed here, but still referenced in other places in package.json. So shall we remove all references of wireit?
There was a problem hiding this comment.
A lot of dev-deps are automatically pulled in via dev-scripts, wireit is one of them
Summary
fetch()withsourceConnection.request()for the export API call, matching how the import already worksfetchwith@typescript-eslint@6^6.0.3to^5.9.3(compatible with@salesforce/dev-scripts@11)fetch to conn.request changes:
{ timeout: SetupTransfer.HTTP_TIMEOUT_MS }in the options argument. Jsforce'sHttpRequestOptionssupports this natively.connection.request()parses the JSON response internally via jsforce'sparseResponseBody. The control-characterstripping was a defensive workaround for raw
fetch().text(). Jsforce handles malformed responses by falling back to the raw body string.Test plan
yarn buildpassesyarn test:onlypasses (9 tests)--definition-identifiermode--extended-definition-filemode@W-22796074@