Fix join point stuck state on dedicated server#942
Merged
notfood merged 2 commits intoMay 30, 2026
Conversation
On a dedicated server no player is ever IsHost (hostUsername is never set), so AbortJoinPointCreation was never called on disconnect. When a client drops mid-join-point creation the server was left stuck in CreatingJoinPoint forever, blocking all subsequent connections at WaitJoinPoint(). Fix: also abort when no joined players remain after a disconnect. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
notfood
added
fix
Member
|
Looks fine. Thanks! |
notfood
added a commit
that referenced
this pull request
May 30, 2026
* Fix join point stuck state on dedicated server On a dedicated server no player is ever IsHost (hostUsername is never set), so AbortJoinPointCreation was never called on disconnect. When a client drops mid-join-point creation the server was left stuck in CreatingJoinPoint forever, blocking all subsequent connections at WaitJoinPoint(). Fix: also abort when no joined players remain after a disconnect. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Update log message --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Meru <notfood@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #941.