Arrange for subcommands to time out#43
Open
ctz wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds explicit timeouts to the subprocesses executed by ci-bench-runner so that CI benchmark jobs cannot hang indefinitely when external commands (git/cargo/bench runs) stall.
Changes:
- Refactors
run_commandto spawn the subprocess, drain stdout/stderr concurrently, and enforce a timeout via polling + kill. - Threads timeout values through each
run_commandcall site (quick git ops vs cargo build vs benchmark/test runs). - Introduces timeout constants for the different command categories.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ctz
force-pushed
the
jbp-command-timeout
branch
4 times, most recently
from
9983ab3 to
071d0a2
Compare
Member
Author
|
since review:
currently deployed version is 02ad654 -- see https://bench.rustls.dev/info |
cpu
reviewed
Jul 7, 2026
Comment on lines
+204
to
+206
| unsafe { | ||
| libc::killpg(child.id() as libc::pid_t, libc::SIGKILL); | ||
| } |
Member
There was a problem hiding this comment.
huh, I'm a little surprised we have to use libc/unsafe for this. Bummer.
cpu
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.