Add stdarch-gen-common: shared check/bless harness for generators#2157
Open
xonx4l wants to merge 1 commit into
Open
Add stdarch-gen-common: shared check/bless harness for generators#2157xonx4l wants to merge 1 commit into
xonx4l wants to merge 1 commit into
Conversation
Member
|
For a bit more context, this is done for the stdarch GSoC project, where we try to integrate stdarch's tests in rust-lang/rust's CI. We want to move the blessing logic out of the CI YAML files and into Rust, to make it easier to reuse, and also share code amongst the various generators. I'll take a look, but also CC @folkertdev , in case you have in mind who owns this code amongst the stdarch maintainers and who could also chime in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a library crate
stdarch-gen-commonthat gives every generator three modes -:Mode is picked via the
STDARCH_GEN_MODEenv var. The harness only touches files the generator explicitly lists as its own so hand-written files in the same directory are safe.This PR also hooks
stdarch-gen-hexagonto use it as the first example.r? @folkertdev