Fix stale rundeck-ec2-nodes-plugin mapping - #12
Merged
Conversation
mapping.tsv and reference.md didn't list rundeck-ec2-nodes-plugin at all, and reference.md called its rundeckpro property vestigial/unused. Verified against the actual rundeckpro checkout: it's a live pluginLibs dependency in plugins/cloud-aws-plugins/build.gradle, and rundeckpro is already pinned to the latest release (2.0.2). Confirmed with check-versions.sh.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the skills/rundeck-plugin-versions source-of-truth mapping to include rundeck-ec2-nodes-plugin, and corrects the documentation to reflect that its rundeckEc2NodesPluginVersion property is actively consumed by rundeckpro (not vestigial). This supports accurate version validation and reporting (including the release-drift work referenced in #11).
Changes:
- Add
rundeck-ec2-nodes-plugin→rundeckEc2NodesPluginVersiontomapping.tsv. - Add the same entry to the human-readable reference table in
reference.md. - Remove/replace the prior documentation claim that the rundeckpro property is “currently not in the operative dependency list,” and add an explicit “Gotchas” note stating it is an active dependency.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| skills/rundeck-plugin-versions/reference.md | Adds the EC2 nodes plugin mapping and corrects the narrative around its rundeckpro property being actively consumed. |
| skills/rundeck-plugin-versions/mapping.tsv | Adds the missing machine-readable mapping entry for rundeck-ec2-nodes-plugin. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
rundeck-ec2-nodes-plugintomapping.tsvandreference.md, andremoves the incorrect claim that its rundeckpro property is vestigial.
Why
The plugin was missing from both files entirely, and reference.md said its
rundeckEc2NodesPluginVersionproperty in rundeckpro was defined but"currently not in the operative dependency list." Checked directly against
the local rundeckpro checkout: it's a live
pluginLibsdependency inplugins/cloud-aws-plugins/build.gradle.check-versions.sh --plugin rundeck-ec2-nodes-pluginnow reportsOK(rundeckpro is already pinned tothe latest release, 2.0.2).
This came up while scoping the new release-drift check (see #11) - that
work is why the plugin's actual bundling status needed to be nailed down
rather than assumed.