Skip to content

Fixed a problem with x-wr-calname#5

Open
ctide wants to merge 2 commits into
rubyredrick:masterfrom
ctide:master
Open

Fixed a problem with x-wr-calname#5
ctide wants to merge 2 commits into
rubyredrick:masterfrom
ctide:master

Conversation

@ctide

@ctide ctide commented Apr 1, 2011

Copy link
Copy Markdown

I was running into an issue where adding the x-wr-calname property was being returned as:

X-WR-CALNAME::Lifetracker

Which causes the calendar name to show up in apps as ':Lifetracker'. I added a spec for it, and fixed where you were adding the colon in. All the specs passed afterwards, so I have to assume this was only really affecting this one property.

Sorry about the context -> describes, my rspec didn't like them in that file for some reason!

@thekidreport

Copy link
Copy Markdown

I'm looking forward to this fix, too.

@ctide

ctide commented Apr 27, 2011

Copy link
Copy Markdown
Author

You can use my fork at : https://github.com/ctide/ri_cal in the mean time, which has this fix.

@sstarr

sstarr commented Jun 10, 2011

Copy link
Copy Markdown

Thanks ctide, using your fork has saved me a headache :)

@ctide

ctide commented Jun 10, 2011

Copy link
Copy Markdown
Author

np!

@jamesbebbington

Copy link
Copy Markdown

@rubyredrick could you accept this pull request, pretty please.

@JangoSteve

Copy link
Copy Markdown

Also having this problem. +1

@annard

annard commented Oct 3, 2011

Copy link
Copy Markdown

Same issue here, should be merged in original repo. +1

@wizardishungry

Copy link
Copy Markdown

Any idea why this isn't being merged?

wizardishungry added a commit to wizardishungry/mta-status-ical that referenced this pull request Sep 20, 2012
@adriand

adriand commented Oct 10, 2012

Copy link
Copy Markdown

I have this problem too - accepting this pull request would be great, @rubyredrick

@julescarbon

Copy link
Copy Markdown

Bump - thanks for this gem @rubyredrick, please merge this

@ches

ches commented Nov 16, 2012

Copy link
Copy Markdown

I was honestly worried that @rubyredrick wasn't okay, but his Twitter account has become active again and he's pushed to his dotfiles repo recently. Issues on this repo are now closed. Rick, please, this library implements a major RFC -- can you put out a call for co-maintainers and try to find someone else worthy of push access and gem releases if you're unable to keep up with maintenance? Thank you very much for all the work you've done.

tfausak added a commit to CampusLabs/ri_cal that referenced this pull request May 11, 2016
@julescarbon

Copy link
Copy Markdown

Oh my gosh this finally got merged?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants