Guard specs needing #fork with guard -> { Process.respond_to?(:fork) } do#1372
Merged
Conversation
… } do` * Previously they would use `platform_is_not :windows do` but fork() is in fact platform-dependent and not available on more than just Windows. Notably, JRuby and TruffleRuby cannot implement #fork because the JVM does not support it (e.g. the GC expects threads to not die suddenly). This seems extremely unlikely to change so IOW the JVM is a platform which does not support fork().
eregon
force-pushed
the
guard-fork-specs
branch
2 times, most recently
from
b38f96b to
4e7981f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platform_is_not :windows dobut fork() is infact platform-dependent and not available on more than just Windows.
Notably, JRuby and TruffleRuby cannot implement #fork because the JVM
does not support it (e.g. the GC expects threads to not die suddenly).
This seems extremely unlikely to change so IOW the JVM is a platform
which does not support fork().