Skip to content

feat(setup): improve skipped setup log #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Aug 3, 2026
Merged

feat(setup): improve skipped setup log #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/rstack/src/setup/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { parseArgs } from 'node:util';
import { color } from 'rslog';
import { color, logger } from 'rslog';
import { installHooks } from './install.ts';

const helpMessage = `Rstack v${RSTACK_VERSION}
Expand Down Expand Up @@ -45,7 +45,7 @@ export const runSetupCLI = (args: string[]): void => {
if (result.status === 'skipped') {
const reason =
result.reason === 'disabled' ? 'disabled by RSTACK_HOOKS' : 'not a Git repository';
console.log(`Git hooks setup skipped: ${reason}.`);
logger.info(`Git hooks setup skipped: ${color.yellow(reason)}.`);
return;
}

Expand Down
4 changes: 2 additions & 2 deletions packages/rstack/tests/cli/setup/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,15 @@ test('installs a custom hooks directory from a nested project', ({ execCli, expe

test('skips non-Git directories without creating files', ({ execCli, expect }) => {
expect(execCli('setup', { cwd, env })).toContain(
'Git hooks setup skipped: not a Git repository.',
'info Git hooks setup skipped: not a Git repository.',
);
expect(existsSync(path.join(cwd, '.rstack'))).toBe(false);
});

test('skips setup when hooks are disabled', ({ execCli, expect }) => {
const output = execCli('setup', { cwd, env: { ...env, RSTACK_HOOKS: '0' } });

expect(output).toContain('Git hooks setup skipped: disabled by RSTACK_HOOKS.');
expect(output).toContain('info Git hooks setup skipped: disabled by RSTACK_HOOKS.');
expect(existsSync(path.join(cwd, '.rstack'))).toBe(false);
});

Expand Down