perf(fmt): use synchronous file I/O in workers - #142
Merged
Conversation
Deploying rstack-cli with
|
| Latest commit: |
18fcabd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://270c6116.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-perf-fmt-direct-w.rstack-cli.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18fcabdb6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces
atomicallywith synchronousnode:fsreads and writes inside dedicated formatting workers, avoiding libuv scheduling and atomic replacement overhead. On the Outline benchmark (2,516 files, 2,374 changed), mean wall time improved by 12.4% with 15 workers and 22.6% with 8 workers compared withatomicallyusingfsync: false.Writes are no longer crash-safe atomic replacements; formatting output is reproducible, and each synchronous operation blocks only its own worker. The unused atomic-write dependencies and notices are removed, and the tests now cover native file-system write failures.