perf(fmt): disable fsync for atomic writes - #141
Merged
Conversation
Deploying rstack-cli with
|
| Latest commit: |
1e854fe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://38dd5807.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-perf-fmt-disable.rstack-cli.pages.dev |
chenjiahan
force-pushed
the
chenjiahan/perf-fmt-disable-fsync
branch
from
August 3, 2026 03:44
f0c27d1 to
1e854fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per-file
fsyncdominatesrs fmtparallel write time for large repositories even though formatter output can be regenerated.This disables
fsyncforatomicallywrites while preserving temporary-file and rename-based atomic replacement, and adds a regression assertion for the write options.The tradeoff is weaker durability if the OS crashes or loses power immediately after formatting; on the Outline fixture (2,516 files, 2,374 rewritten), parallel formatting on an M3 Max improved from approximately 12.7s to 2.2s.
Related Links