[textinput] mv to builtins dir as hard-coded builtin - #23046
Open
ferdymercury wants to merge 1 commit into
Open
Conversation
This library was thought as standalone library, and in fact has a separate license from ROOT. It has its own namespace, etc. Make that clearer by moving it to builtins dir as hard-coded builtin such as mathtext or libafterimage This will make the granularity and modularity clearer eg for Debian package maintainers for a future migration. It would allow them to have it as separate package rather than a big monolithic libCore library. And one could consider later replacing it with llvm textinput or other drop in replacements, without having to touch ROOT core folder. Makes clearer what is inside ROOT and what is an independent outside component that can be externalized or changed to other lib.
ferdymercury
added
the
skip code analysis
ferdymercury
marked this pull request as ready for review
August 7, 2026 07:44
ferdymercury
requested review from
bellenot,
couet,
dpiparo and
pcanal
as code owners
August 7, 2026 07:44
Test Results 23 files 23 suites 3d 16h 4m 29s ⏱️ For more details on these failures, see this check. Results for commit 7980653. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
A standalone library that could be swapped in the future with another one, eg LLVM's, does not make sense to lie inside the "Core" ROOT folder, it's kind of an outside dependency, not central to ROOT's core system.
This textinput library was thought as standalone library, and in fact has a separate license from ROOT. It has its own namespace, etc. Make that clearer by moving it to builtins dir as hard-coded builtin such as mathtext or libafterimage
This will make the granularity and modularity clearer eg for Debian package maintainers for a future migration. It would allow them to have it as separate package rather than a big monolithic libCore library. And one could consider later replacing it with llvm textinput or other drop in replacements, without having to touch ROOT core folder.
Makes clearer what is inside ROOT and what is an independent outside component that can be externalized or changed to other lib.
In a future modularization step, one could make this a full separate library linked by core via target_link_libraries. Now is just a cosmetic / logic directory structure reorganization, such as with mathtext, etc.
Checklist: