[cmake] Do not auto-turn OFF feature or auto-turn ON builtin_option - #23020
[cmake] Do not auto-turn OFF feature or auto-turn ON builtin_option#23020ferdymercury wants to merge 1 commit into
Conversation
93f2ae0 to
442243a
Compare
Test Results 23 files 23 suites 3d 14h 35m 35s ⏱️ Results for commit 375b1cb. ♻️ This comment has been updated with latest results. |
14f7899 to
98c555c
Compare
for easy-to-install dependencies (via homebrew, apt-get) when dependency is missing in the system. Instead, force user to install it via package manager, or to turn feature purposely OFF. [nfc] improve error messages Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
98c555c to
375b1cb
Compare
After some usage, I find this change to be indeed more pedantic (useful for system maintainer) but also annoyingly-so for the 'quickly build ROOT on this system for my private usage' (I.e. now installing ROOT on a system that does not already have the required builtin has to go through a step of parsing (by hand or mechanically) the output of cmake to find the so I am not (yet?) convinced that completely removing the feature (auto-turn on) is desirable. |
|
I think AI could do that parsing and -Dbuiltin=On for you to paste on the terminal. One could also improve the printed error messages so that Root already proposes -Dbuiltin1=ON ... In a one liner rather than scattered as now
Can't you install instead the dependencies via homebrew or apt? So that you don't need to parse anything, just copy paste packages.txt from rootci images? I think more developer time is spent on maintaining those many code branches (and bugs) than the time spent in writing by hand built-in On. |
2 participants
for easy-to-install dependencies (via homebrew, apt-get)
when dependency is missing in the system. Instead, force user to install it via package manager, or to turn feature purposely OFF by hand.
Spit-off from #23015 as suggested by @guitargeek
This goes totally in-line with what's already done for asimage, zlib, etc.