Adds strict mode.#1732
Open
markwpearce wants to merge 7 commits into
Open
Conversation
…lterFile()->canSkipScopeValidationForFile()
…'changeUnknownMemberToDynamic'
markwpearce
commented
Jun 15, 2026
| * If the file diagnostics are ignored, we do not need to validate this file | ||
| */ | ||
| public isFileFiltered(file: { srcPath: string; destPath: string }) { | ||
| public isFileCompletelyFiltered(file: { srcPath: string; destPath: string }) { |
Collaborator
Author
There was a problem hiding this comment.
Changed name to make function more clear
markwpearce
commented
Jun 15, 2026
| * If so, we can skip any Scope-based validation on this file at all, which can save a lot of time for large files | ||
| * with many diagnostics that are being ignored | ||
| */ | ||
| public canSkipScopeValidationForFile(file: BrsFile): boolean { |
Collaborator
Author
There was a problem hiding this comment.
changed name to make function use more clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
strictmode option tobsconfig.json, set by default tofalseWhat does
strictmode do?dynamic, because Node member types can be updated (eg. throughaddField,update, etc). When Strict mode is on, unknown members will not be resolvedroSGNode: If strict mode is on, trying to do acallfuncon a generic node will give acannot-find-callfuncerror. By default, this is simply not validated.If strict mode is on, it forces the developer to typecast the Nodes so they have known members.