Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend agent table public permissions #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Backend agent table public permissions #1865
Changes from all commits
0b68b985c6d6ccFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: rocket-admin/rocketadmin
Length of output: 27009
🏁 Script executed:
Repository: rocket-admin/rocketadmin
Length of output: 9646
🏁 Script executed:
Repository: rocket-admin/rocketadmin
Length of output: 19972
Sensitive Data Exposure (CWE-200): Exposure of Sensitive Information to an Unauthorized Actor
Reachability: Internal
Reachability path
Block wildcard public grants that can include the password field.
readableColumnsomitted or empty generates an all-column public grant. The current check only rejects an explicitpasswordFieldentry, so a non-auth table containing that credential field can still be exposed. ExpandreadableColumnsbefore this check, or reject wildcard grants while a site policy definespasswordField.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: rocket-admin/rocketadmin
Length of output: 7274
🏁 Script executed:
Repository: rocket-admin/rocketadmin
Length of output: 7755
🏁 Script executed:
Repository: rocket-admin/rocketadmin
Length of output: 6331
🌐 Web query:
jsonwebtoken v9 expiresIn accepts number milliseconds seconds valid duration string💡 Result:
In jsonwebtoken v9, the expiresIn option is interpreted differently depending on whether you provide a number or a string [1][2]. When you provide a number, it is interpreted as the count in seconds (e.g., 60 means 60 seconds) [1][3]. When you provide a string, it must be a valid time span string (e.g., "2 days", "10h", "7d") [1][2]. If the string does not specify a unit, it is interpreted as milliseconds by default (e.g., "120" is treated as "120ms") [1][3]. To avoid confusion when using strings, it is recommended to explicitly include the time units (such as "s", "m", "h", "d") [1].
Citations:
Validate
ENDUSER_TOKEN_TTLat config load.SITENOVA_ENDUSER_TOKEN_TTLaccepts any non-empty string and passes it tojwt.sign({ expiresIn: ... }). A bare value such as120is read as milliseconds, and an invalid duration can make SignUser login or request token signing blow up. Validate the duration up front and fail startup instead of deferring the failure to JWT creation.🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.