Skip to content

fix(android): register compat Kotlin source dirs for AGP 8.9+ (RN 0.86) #4264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joaquinvaz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(android): register compat Kotlin source dirs for AGP 8.9+ (RN 0.86) #4264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,18 @@ Please upgrade to Mapbox v11.x or use @rnmapbox/maps 10.2.x
}
}

// AGP 8.9+ (bundled with RN 0.86 / Gradle 8.x) no longer feeds
// extra java.srcDirs into the Kotlin compile task. The compat
// directories appended above (mapbox-v11-compat, rn-compat and the
// selected lifecycle-compat variant) contain only Kotlin sources,
// so without this they are silently skipped and their packages
// (e.g. com.rnmapbox.rnmbx.v11compat) fail to resolve. Mirror the
// Java source dirs onto the Kotlin source set to keep them compiled.
// Guarded by the same impl check as the `kotlin-android` plugin
// above, since only that impl registers the `kotlin` source set.
if (safeExtGet("RNMapboxMapsImpl", defaultMapboxMapsImpl) == "mapbox") {
kotlin.srcDirs(java.srcDirs)
}
}
}

Expand Down
Loading