fix(android): bump rive-android to 11.6.2#317
Open
mfazekas wants to merge 1 commit into
Open
Conversation
1 task
11.6.2 backports the ViewModelInstance read/write lock from 11.7.0 (without the 11.7.x Vulkan default flip). In 11.6.1, state-machine advance holds the file lock but ViewModelInstance property access takes no lock, so a property write or instance teardown on another thread can race the advance path's DataBindContainer::updateDataBinds and crash.
mfazekas
force-pushed
the
fix/android-rive-11.6.2
branch
from
a88afa2 to
89378b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pinned Android runtime from 11.6.1 to 11.6.2, which backports the ViewModelInstance read/write lock from 11.7.0 without the 11.7.x Vulkan default flip.
In 11.6.1,
StateMachineInstance.advance()holds the file lock but ViewModelInstance property access takes no lock, so a property write or instance teardown on another thread can race the advance path'sDataBindContainer::updateDataBindsand crash (SIGSEGV reported in production on 0.4.11). Related ledger: #308.Verified on a Pixel 6 API 34 emulator (arm64 debug build): the databinding-related harness suites and a targeted advance-vs-write stress loop are green on both 11.6.1 and 11.6.2 (the race did not reproduce locally at this volume; no regressions from the bump).