fix(ios): use C++17 for fmt pod (FMT_USE_CONSTEVAL=0 from #314 does not build)#315
Open
mfazekas wants to merge 1 commit into
Open
fix(ios): use C++17 for fmt pod (FMT_USE_CONSTEVAL=0 from #314 does not build)#315mfazekas wants to merge 1 commit into
mfazekas wants to merge 1 commit into
Conversation
…#314 does not build) The merged #314 fmt workaround (define FMT_USE_CONSTEVAL=0) does NOT fix the Xcode 26.4+ consteval error: fmt/base.h re-#defines FMT_USE_CONSTEVAL unconditionally, overriding the command-line define, so the build still fails (verified failing on Xcode 26.6). Compiling the fmt pod as C++17 makes base.h itself disable consteval (FMT_CPLUSPLUS < 201709). Verified building on Xcode 26.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #314. The merged fmt workaround (define
FMT_USE_CONSTEVAL=0) does not actually fix the Xcode 26.4+ (Apple clang 21) consteval error:fmt/base.hre-#definesFMT_USE_CONSTEVALunconditionally (it is not#ifndef-guarded), so it overrides the command-line define and the build still fails. Verified failing on Xcode 26.6.Switches to compiling the
fmtpod as C++17, which makes fmt's ownbase.hdisable consteval (FMT_CPLUSPLUS < 201709→FMT_USE_CONSTEVAL 0). Verified building on Xcode 26.6. CI (Xcode 26.3) does not hit the consteval error, so this only affects local builds on 26.4+.Same approach as #306 (the main-line fmt PR). Real fix is upstream in React Native 0.83+.