feat: add received_for to inbound email and received webhook types#991
Closed
platoresend wants to merge 3 commits into
Closed
feat: add received_for to inbound email and received webhook types#991platoresend wants to merge 3 commits into
platoresend wants to merge 3 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
commit: |
Contributor
There was a problem hiding this comment.
No issues found across 6 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Adds missing received_for and message_id fields to TypeScript types, aligning the SDK with existing API responses; no logic or infrastructure changes.
Re-trigger cubic
Contributor
|
Superseded by #993, which targets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Slack thread
Opened on behalf of: @lucasfcosta
What
Adds the new
received_forfield (merged in resend-monorepo #4637) to the SDK types.GetReceivingEmailResponseSuccess(src/emails/receiving/interfaces/get-receiving-email.interface.ts) — theemails.receiving.getresponse now includesreceived_for: string[].ReceivedEmailEventData(src/webhooks/interfaces/webhook-event.interface.ts) — theemail.receivedwebhook payload now includesreceived_for: string[].Why
The field is already returned by the GET
/emails/receiving/:idroute and theemail.receivedwebhook; the SDK types were missing it.How
Typed fixtures in
receiving.spec.tsupdated to include the now-required field; inline snapshots regenerated.pnpm typecheckandpnpm lintclean (pre-existingtsconfigmoduleResolution=node10deprecation is unrelated).Summary by cubic
Add received_for to inbound email responses and email.received webhooks so the SDK matches the API. Also expose message_id on get/list email responses.
GetReceivingEmailResponseSuccess: addsreceived_for: string[].ReceivedEmailEventData(email.received webhook): addsreceived_for: string[].GetEmailResponseSuccess: addsmessage_id.Written for commit da86148. Summary will update on new commits.