fix(tailwind): convert rgba() space syntax to comma syntax#3589
Open
yashs33244 wants to merge 1 commit into
Open
fix(tailwind): convert rgba() space syntax to comma syntax#3589yashs33244 wants to merge 1 commit into
yashs33244 wants to merge 1 commit into
Conversation
sanitizeDeclarations only matched the rgb() function name, so colors written as rgba(R G B / A) (space/slash syntax) survived into the inlined email CSS, which Outlook and other legacy clients don't parse. Handle rgba() the same way, but only for the space/slash form; legacy comma rgba(r, g, b, a) is left as-is since it's already well supported.
Contributor
|
@yashs33244 is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 0c11c63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Targeted bug fix adding rgba() conversion alongside rgb() handling. It touches a core email rendering path, so despite looking correct and tested, human review is warranted.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sanitizeDeclarationsnormalizes modern space/slash color syntax into the comma syntax that Outlook and other legacy email clients understand, but thergb()branch is gated on the function name only:So a Tailwind color written as
rgba(R G B / A)is never converted and survives into the inlined CSS:Fix
Run the same conversion for
rgba(), but only for the space/slash form. Legacy commargba(r, g, b, a)is left untouched, since it already renders and is more widely supported in email clients than 4-argumentrgb(). Added regression cases (including one asserting legacy commargba()is preserved). All existing tailwind tests pass.Summary by cubic
Convert Tailwind
rgba()colors written in space/slash syntax to comma syntax during CSS sanitization so Outlook and other legacy email clients parse them correctly. Legacy commargba(r, g, b, a)is preserved.rgba(R G B / A)torgb(R,G,B,A); only applies to space/slash form.rgba()preservation).Written for commit 0c11c63. Summary will update on new commits.