fix(heading): keep unit on margin values like mx="2rem"#3588
Open
yashs33244 wants to merge 1 commit into
Open
Conversation
withSpace appended px to any value whose leading number parsed, so a string with a unit (mx="2rem", my="10%") became invalid CSS like "2rempx". Suffix px only for bare numbers; pass unit values through.
Contributor
|
@yashs33244 is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: b86d9ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Fixes a CSS unit handling bug in Heading margin props, adding a simple regex check to pass through strings with units. The change is small, well-tested, and does not affect core logic or other components.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Headingacceptsm/mx/my/mt/mr/mb/mlasnumber | string, butwithSpaceappendedpxto any value whose leading number parsed. So a string that already carries a unit produced invalid CSS:parseFloat("2rem")is2(not NaN), so the existing guard let it through and${value}pxmangled it.Fix
Suffix
pxonly when the value is a bare number (or a unitless numeric string). Strings that already have a unit are passed through untouched. Numbers and unitless strings likemx={4}/mx="20"are unchanged. Added a regression test inutils.spec.ts.Summary by cubic
Fixes
Headingmargin props to keep units (e.g., mx="2rem", my="10%") and only add "px" for bare numbers, preventing invalid CSS. Unitless numbers and numeric strings still get "px".withSpaceto detect unit-bearing strings and pass them through unchanged.rem,%, andem(including negative values) inutils.spec.tsforreact-email.Written for commit b86d9ff. Summary will update on new commits.