fix: dispose owned scroll controllers and floating-cursor timer - #119
Open
SebTardif wants to merge 1 commit into
Open
fix: dispose owned scroll controllers and floating-cursor timer#119SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
CodeScrollController allocated default ScrollControllers but dispose() only cleared the editor key, leaking two controllers per default editor. Track ownership and dispose only controllers we create. Also cancel _floatingCursorScrollTimer in _CodeInputController.dispose so disposing mid-edge-drag cannot leave a periodic timer on a detached controller. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two resource-lifetime fixes in the editor:
ScrollControllers when the caller omitted them, butdispose()only cleared the editor key, leaking two controllers per default editor instance. Track ownership and dispose only controllers we create.Timerthat was cancelled on gesture end, but not indispose(), so disposing the input controller mid-drag could leave a live timer on a detached object.Testing
_floatingCursorScrollTimerand dispose owned scroll controllers onlyCloses resource-leak audit items F001 and F005.