Skip to content

Normalize Uniswap Wallet connector name (INT2-1044) - #1098

Closed
pedromcunha wants to merge 2 commits into
mainfrom
pedro/int2-1044-relay-app-permits-unsupported-uniswap-origin-chain
Closed

Normalize Uniswap Wallet connector name (INT2-1044)#1098
pedromcunha wants to merge 2 commits into
mainfrom
pedro/int2-1044-relay-app-permits-unsupported-uniswap-origin-chain

Conversation

@pedromcunha

Copy link
Copy Markdown
Member

No description provided.

@pedromcunha
pedromcunha requested a review from ted-palmer August 3, 2026 20:31
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
relay-sdk-demo Ready Ready Preview Aug 3, 2026 8:35pm

Request Review

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished @pedromcunha's task in 26s —— View job


Code Review

  • Gather context (PR diff, commits)
  • Analyze changes
  • Post review

Code Review — No issues found.

This PR has no net changes against origin/main (git diff origin/main...HEAD is empty — 0 files, 0 lines). The intended change — adding the Uniswap Wallet connector name to packages/ui/src/constants/walletCompatibility.ts (commit 1861b1fe) — was already merged to main via #1094 (4ed69051). The merge commit 3dfd8fa5 then pulled main back into this branch, so there is nothing left to review here.

You can safely close this PR as its content is already on main.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished @pedromcunha's task in 45s —— View job


📝 Docs Drift Check — No docs impact

This PR does not touch surfaces that require a relayprotocol/relay-docs update.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished @pedromcunha's task in 35s —— View job


📝 Docs Drift Check — No docs impact

This PR does not touch surfaces that require a relayprotocol/relay-docs update.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished @pedromcunha's task in 46s —— View job


Code Review

  • Gather context (PR diff, commits, changed files)
  • Review the change
  • Post review

Code Review — No issues found (empty diff).

This PR currently has no net changes against origin/main. The intended change — adding uniswapwallet: 'uniswap' to NormalizedWalletName in packages/ui/src/constants/walletCompatibility.ts — was already merged into main as #1094 (commit 4ed69051). Merging main back into this branch (3dfd8fa5) brought that same commit in, so git diff origin/main...HEAD returns nothing.

For reference, the change itself is correct and safe: uniswapwallet normalizes to uniswap, which has chain restrictions defined in WalletChainRestricted (walletCompatibility.ts:7-9), so those restrictions now apply. It mirrors the existing robinhoodwallet → robinhood / roninwallet → ronin pattern exactly.

Recommendation: Since the fix already landed via #1094, this PR can likely be closed unless you intend to add further changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant