feat(relay): promote attribute release to default #488
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| mod build_support; | ||
|
|
||
| use std::env; | ||
| use std::fs; | ||
| use std::path::PathBuf; | ||
|
|
||
| fn main() { | ||
| println!("cargo:rerun-if-changed=Cargo.toml"); | ||
| println!("cargo:rerun-if-env-changed=REGISTRY_RELAY_FEATURES"); | ||
|
|
||
| let manifest = | ||
| fs::read_to_string("Cargo.toml").expect("registry-relay Cargo.toml must be readable"); | ||
| let declared = build_support::declared_feature_names(&manifest) | ||
| .expect("registry-relay Cargo features must be readable"); | ||
| let mut enabled = declared | ||
| .iter() | ||
| .filter(|feature| { | ||
| let environment_name = | ||
| format!("CARGO_FEATURE_{}", feature.replace('-', "_").to_uppercase()); | ||
| env::var_os(environment_name).is_some() | ||
| }) | ||
| .cloned() | ||
| .collect::<Vec<_>>(); | ||
| enabled.sort(); | ||
|
|
||
| if let Ok(requested) = env::var("REGISTRY_RELAY_FEATURES") { | ||
| build_support::validate_requested_profile(&requested, &declared, &enabled) | ||
| .unwrap_or_else(|error| panic!("invalid Registry Relay feature profile: {error}")); | ||
| } | ||
|
|
||
| let generated = format!( | ||
| "const COMPILED_CARGO_FEATURES: &[&str] = &[\n{}\n];\n", | ||
| enabled | ||
| .iter() | ||
| .map(|feature| format!(" {feature:?},")) | ||
| .collect::<Vec<_>>() | ||
| .join("\n") | ||
| ); | ||
| let output = PathBuf::from(env::var_os("OUT_DIR").expect("Cargo must provide OUT_DIR")) | ||
| .join("compiled_cargo_features.rs"); | ||
| fs::write(output, generated).expect("compiled feature inventory must be writable"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| use std::collections::BTreeSet; | ||
|
|
||
| pub fn declared_feature_names(manifest: &str) -> Result<Vec<String>, String> { | ||
| let document = manifest | ||
| .parse::<toml::Table>() | ||
| .map_err(|error| format!("Cargo.toml is not valid TOML: {error}"))?; | ||
| let features = document | ||
| .get("features") | ||
| .and_then(toml::Value::as_table) | ||
| .ok_or_else(|| "Cargo.toml must contain a [features] table".to_string())?; | ||
| Ok(features | ||
| .keys() | ||
| .filter(|feature| feature.as_str() != "default") | ||
| .cloned() | ||
| .collect()) | ||
| } | ||
|
|
||
| pub fn validate_requested_profile( | ||
| requested: &str, | ||
| declared: &[String], | ||
| enabled: &[String], | ||
| ) -> Result<(), String> { | ||
| if requested | ||
| .bytes() | ||
| .any(|byte| !matches!(byte, b'a'..=b'z' | b'0'..=b'9' | b'-' | b',')) | ||
| { | ||
| return Err("use comma-separated Cargo feature names".to_string()); | ||
| } | ||
| if requested.starts_with(',') || requested.ends_with(',') || requested.contains(",,") { | ||
| return Err("feature list must not contain empty entries".to_string()); | ||
| } | ||
|
|
||
| let requested = if requested.is_empty() { | ||
| Vec::new() | ||
| } else { | ||
| requested.split(',').map(str::to_string).collect::<Vec<_>>() | ||
| }; | ||
| let requested_set = requested.iter().collect::<BTreeSet<_>>(); | ||
| if requested_set.len() != requested.len() { | ||
| return Err("feature list must not contain duplicates".to_string()); | ||
| } | ||
|
|
||
| let mut canonical = requested.clone(); | ||
| canonical.sort(); | ||
| if requested != canonical { | ||
| return Err(format!( | ||
| "feature list must use canonical order: {}", | ||
| canonical.join(",") | ||
| )); | ||
| } | ||
|
|
||
| let declared = declared.iter().collect::<BTreeSet<_>>(); | ||
| let unknown = requested | ||
| .iter() | ||
| .filter(|feature| !declared.contains(feature)) | ||
| .cloned() | ||
| .collect::<Vec<_>>(); | ||
| if !unknown.is_empty() { | ||
| return Err(format!("unknown Cargo features: {}", unknown.join(","))); | ||
| } | ||
|
|
||
| let enabled = enabled.iter().collect::<BTreeSet<_>>(); | ||
| let missing = enabled | ||
| .difference(&requested_set) | ||
| .map(|feature| feature.as_str()) | ||
| .collect::<Vec<_>>(); | ||
| let inactive = requested_set | ||
| .difference(&enabled) | ||
| .map(|feature| feature.as_str()) | ||
| .collect::<Vec<_>>(); | ||
| if !missing.is_empty() || !inactive.is_empty() { | ||
| return Err(format!( | ||
| "requested profile does not match Cargo's effective feature set \ | ||
| (missing: [{}], inactive: [{}])", | ||
| missing.join(","), | ||
| inactive.join(",") | ||
| )); | ||
| } | ||
| Ok(()) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| attribute-release,crosswalk-runtime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.