[feat] Add a new count aggregation for querying past results#3691
Open
sschmittgwdg wants to merge 3 commits into
Open
[feat] Add a new count aggregation for querying past results#3691sschmittgwdg wants to merge 3 commits into
count aggregation for querying past results#3691sschmittgwdg wants to merge 3 commits into
Conversation
Signed-off-by: Sebastian Schmitt <sebastian.schmitt@gwdg.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3691 +/- ##
========================================
Coverage 91.96% 91.97%
========================================
Files 62 62
Lines 13773 13788 +15
========================================
+ Hits 12666 12681 +15
Misses 1107 1107 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vkarak
added
prio: normal
enhancement
reporting
vkarak
changed the title
vkarak
requested changes
Jul 7, 2026
vkarak
left a comment
vkarak
left a comment
Contributor
There was a problem hiding this comment.
We will also need to update the docs.
| elif aggregator == 'p05': | ||
| assert agg['pval (p99)'][0] == 10 | ||
| elif aggregator == 'count': | ||
| assert 'pval (count)' in agg.columns |
Contributor
There was a problem hiding this comment.
You will need to assert also the value here as with the other aggregations above.
Contributor
Author
There was a problem hiding this comment.
Thanks and done.
vkarak
changed the title
count aggregation for querying past results
vkarak
changed the title
count aggregation for querying past resultscount aggregation for querying past results
Signed-off-by: Sebastian Schmitt <sebastian.schmitt@gwdg.de>
Contributor
Author
|
I've added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.