Build native core during contributor setup#93
Draft
Alek99 wants to merge 1 commit into
Draft
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make setupmake setupand document its Rust requirementRoot cause
The contributor quick start only created a virtual environment and installed the project editable. An editable install can complete without leaving
libxy_corein one of the development loader paths, so the documentedmake checkstep then fails while importingxy.kernels.make setupnow runscargo build --releaseexplicitly, ensuring a source checkout is ready for the documented fast gate.Closes #77.
Validation
XY_SKIP_CARGO=1forced the editable-install path to omit the core; the explicit setup build then producedtarget/release/libxy_core.dylibandxy.kernels.BACKEND == "native".venv/bin/python -m pytest -q tests/test_verify_local.py— 62 passedmake check-docs— claim guardrails passed and 68 tests passedgit diff --checkThe broader
make checkrun reached 1,843 passed and 66 skipped tests, with one unrelated local Chromium alignment failure intest_midpoint_annotation_labels_are_visually_centered; this patch does not change chart rendering or browser assets.