Skip to content

architecture: Don't mention SMP#1756

Merged
JakeSCahill merged 1 commit into
mainfrom
stephan/remove-smp
Jun 17, 2026
Merged

architecture: Don't mention SMP#1756
JakeSCahill merged 1 commit into
mainfrom
stephan/remove-smp

Conversation

@StephanDollberg

Copy link
Copy Markdown
Member

This confuses SMP. SMP in the context of seastar always refers to symmetric multiprocessing / shared-memory multiprocessing (and the respective --smp seastar flag).

Description

Resolves https://redpandadata.atlassian.net/browse/
Review deadline:

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

This confuses SMP. SMP in the context of seastar always refers to
symmetric multiprocessing / shared-memory multiprocessing (and the
respective --smp seastar flag).
@StephanDollberg StephanDollberg requested a review from a team as a code owner June 17, 2026 16:40
@netlify

netlify Bot commented Jun 17, 2026

Copy link
Copy Markdown

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 2b02a92
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/6a32cdecbbec660009c15137
😎 Deploy Preview https://deploy-preview-1756--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2ff3d039-5033-42d5-bb1d-791e1cb9dd5b

📥 Commits

Reviewing files that changed from the base of the PR and between 3887de6 and 2b02a92.

📒 Files selected for processing (1)
  • modules/get-started/pages/architecture.adoc

📝 Walkthrough

Walkthrough

In modules/get-started/pages/architecture.adoc, the Thread-per-core model section description was changed to replace "structured message passing (SMP)" with "message passing" when describing communication between pinned threads. Additionally, the AsciiDoc // end::single-source[] directive closing marker was adjusted or confirmed at line 101.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing SMP terminology from the architecture documentation to avoid confusion.
Description check ✅ Passed The description provides context for the change and marks the checkbox for 'Small fix', but the Jira ticket link is incomplete (shows placeholder '').
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stephan/remove-smp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JakeSCahill JakeSCahill merged commit 0f04d55 into main Jun 17, 2026
7 checks passed
@JakeSCahill JakeSCahill deleted the stephan/remove-smp branch June 17, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants