proto(sql): add catalog_namespace to table RPCs#2498
Open
r-vasquez wants to merge 2 commits into
Open
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / validate (pull_request).
|
r-vasquez
commented
Jun 11, 2026
Comment on lines
151
to
154
| // Namespace of the catalog that owns this table. Namespaces attach to | ||
| // catalogs (connections), not to tables; tables of same-named catalogs in | ||
| // different namespaces are distinguished by this field. | ||
| string namespace_name = 2; |
Contributor
Author
There was a problem hiding this comment.
Wondering if this should be called catalog_namespace_name @c-julin, wdyt? Are breaking changes allowed in alphav3, or will the CI break?
Contributor
Author
|
Commit: 3b440b2 includes the breaking changes. It's an alpha version so we should be fine as there are no current users of this one. |
Catalog names are only unique within a namespace, so resolving a catalog by name alone is ambiguous when the same name exists in more than one namespace. Add an optional catalog_namespace field to ListTablesRequest and DescribeTableRequest to disambiguate. When unset, ListTables returns tables from all matching catalogs (rows carry Table.namespace_name) while DescribeTable fails with INVALID_ARGUMENT and a documented 400 response. Also reword Column.type docs to the engine-reported names (e.g. "integer", "text[]") instead of Postgres driver names.
Table and Catalog fields carried a redundant _name suffix, and connection_name still used the old "connection" term for what the API now calls a catalog. namespace_name on Table also read as if the namespace belonged to the table rather than the catalog that owns it. Rename the fields to catalog, catalog_namespace, topic, subject, and output_schema_full_message so names match the resource terminology. The renumbering is safe while the v1alpha3 SQL API is unstable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catalog names are only unique within a
namespace, so resolving a catalog by name alone
is ambiguous when the same name exists in more
than one namespace. Add an optional
catalog_namespace field to ListTablesRequest and
DescribeTableRequest to disambiguate. When unset,
ListTables returns tables from all matching
catalogs (rows carry Table.namespace_name) while
DescribeTable fails with INVALID_ARGUMENT and a
documented 400 response.
Also reword Column.type docs to the
engine-reported names (e.g. "integer", "text[]")
instead of Postgres driver names.