-
Notifications
You must be signed in to change notification settings - Fork 96
feat(voyageai): add contextualized embeddings and refresh model support #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fzowl
wants to merge
8
commits into
redis:main
Choose a base branch
from
fzowl:feat/voyageai-refresh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4875fc8
feat(voyageai): add contextualized embeddings and refresh model support
fzowl 1540de3
feat(voyageai): recognize voyage-4 embedding models in batch sizing
fzowl 40ff963
fix(voyageai): gate contextualized auto-chunking to document inputs
fzowl a2e5942
chore(voyageai): minimize uv.lock diff and note context-model caveats
fzowl 809b7bb
docs(voyageai): describe contextualized embeddings as independent per…
fzowl a9d20ee
feat(voyageai): token-aware batching for the text embedding path
fzowl 59318d0
Merge remote-tracking branch 'upstream/main' into feat/voyageai-refresh
fzowl 7024c58
fix(voyageai): default contextualized input_type to document
fzowl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tokenize required for text embeds
Medium Severity
Plain-text embedding now calls
Client.tokenizefor every input via_batchify_by_tokens, including the single-string dimension probe in_set_model_dims. Voyage loads that tokenizer from Hugging Face forvoyageai/{model}, so init andembed_manyfail if the Hub is unreachable or no tokenizer exists for the model id, even when the Voyage embed API itself would succeed.Additional Locations (2)
redisvl/utils/vectorize/voyageai.py#L452-L454redisvl/utils/vectorize/voyageai.py#L303-L304Reviewed by Cursor Bugbot for commit 7024c58. Configure here.