feat(#4037): move app drawer module into app-defaults plugin - #4038
Open
fullsend-ai-coder[bot] wants to merge 3 commits into
Open
feat(#4037): move app drawer module into app-defaults plugin#4038fullsend-ai-coder[bot] wants to merge 3 commits into
fullsend-ai-coder[bot] wants to merge 3 commits into
Conversation
Move appDrawerExtension and appDrawerModule from app-react into the app-defaults plugin where default module registrations belong. The app-react package retains the reusable building blocks (components, hooks, blueprints, data refs) while app-defaults now owns the module that wires them into the app. Changes: - Create plugins/app-defaults/src/appDrawerModule.tsx importing ApplicationDrawer and appDrawerContentDataRef from app-react - Export appDrawerModule as named and default export from alpha.ts - Remove appDrawerModule.tsx and its barrel export from app-react - Update sample app to import from app-defaults/alpha - Update API reports for both packages - Update README documentation for both packages Closes #4037
fullsend-ai-coder
Bot
requested review from
a team,
christoph-jerolimov and
rohitkrai03
as code owners
July 28, 2026 16:55
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4038 +/- ##
=======================================
Coverage 57.87% 57.87%
=======================================
Files 2393 2392 -1
Lines 95985 95980 -5
Branches 26803 26803
=======================================
Hits 55551 55551
+ Misses 38940 38935 -5
Partials 1494 1494
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Member
|
/fs-fix
|
Contributor
Author
|
🤖 Finished Fix · ✅ Success · Started 5:44 PM UTC · Completed 6:09 PM UTC |
Move appDrawerModule and appDefaultsModule exports from the /alpha subpath to the default package entry point of app-defaults. Update the sample app import accordingly. Add CHANGELOG entries with breaking change notices and migration hints: - app-defaults 0.0.2 (patch): appDrawerModule added to default export - app-react 0.2.0 (minor): appDrawerModule removed (moved to app-defaults) Addresses review feedback on #4038
Contributor
Author
🔧 Fix agent — iteration 1 (human-triggered)Addressed both review findings: (1) moved module exports from /alpha to the default package entry point, updated all imports, API reports, and documentation accordingly; (2) added CHANGELOG entries with breaking change notices and migration hints for both app-defaults (0.0.2 patch) and app-react (0.2.0 minor), with version bumps in package.json. Fixed (2):
Tests: passed Decision points
Updated by fullsend fix agent |
Member
|
/fs-fix
|
Contributor
Author
|
🤖 Finished Fix · ✅ Success · Started 7:31 PM UTC · Completed 7:44 PM UTC |
Revert manual CHANGELOG.md entries and version bumps in package.json for both app-defaults and app-react packages. Add a proper changeset file instead, which will generate changelogs and version bumps during the release process. Addresses review feedback on #4038
Contributor
Author
🔧 Fix agent — iteration 2 (human-triggered)Replaced manual CHANGELOG.md entries and version bumps with a proper changeset file. Reverted both CHANGELOG.md files and both package.json version fields. Created workspaces/app-defaults/.changeset/move-drawer-to-app-defaults.md with patch bump for app-defaults and minor bump for app-react. Fixed (5):
Tests: passed Updated by fullsend fix agent |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move appDrawerExtension and appDrawerModule from app-react into the app-defaults plugin where default module registrations belong. The app-react package retains the reusable building blocks (components, hooks, blueprints, data refs) while app-defaults now owns the module that wires them into the app.
Changes:
ApplicationDrawer and appDrawerContentDataRef from app-react
Closes #4037
Post-script verification
agent/4037-move-drawer-to-app-defaults)e03b281a62994a1310c4c4a8dc96e17a1c158f67..HEAD)