Skip to content

chore(RHIDP-14706): update archive script in rhdh-plugins - #4036

Draft
AdamBrez wants to merge 1 commit into
redhat-developer:mainfrom
AdamBrez:chore/RHIDP-14706
Draft

chore(RHIDP-14706): update archive script in rhdh-plugins#4036
AdamBrez wants to merge 1 commit into
redhat-developer:mainfrom
AdamBrez:chore/RHIDP-14706

Conversation

@AdamBrez

Copy link
Copy Markdown
Contributor

Jira ticket: https://redhat.atlassian.net/browse/RHIDP-14706
References of the archived workspace are now automatically removed from the files: codecov.yml, .github/labeler.yml and .github/pr-labeler.yml

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

References of the archived workspace are now automatically removed from the files: codecov.yml, .github/labeler.yml and .github/pr-labeler.yml

Signed-off-by: Adam Brezina <breziinaadam@seznam.cz>
@sonarqubecloud

Copy link
Copy Markdown

@04kash 04kash left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just address the SonarCloud warning to "Use .indexOf() instead of .findIndex() when looking for the index of an item." and this should be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants