Skip to content

docs(#4025): add build commands and import conventions to boost AGENTS.md - #4026

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/4025-boost-agents-conventions
Open

docs(#4025): add build commands and import conventions to boost AGENTS.md#4026
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/4025-boost-agents-conventions

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Add two new sections to the boost workspace AGENTS.md to prevent recurring CI failures and convention violations in agent-generated PRs:

  • Build & verify: command table covering build, type-check, lint,
    test, API reports, and OpenSpec validation. Includes guidance to
    run yarn build:api-reports after modifying API surface files.
  • Import conventions: documents @remixicon/react as the standard
    icon library (not @mui/icons-material) and .toLowerCase()
    normalization for spec.type comparisons.

These gaps caused preventable failures on PR #3747: a missing report.api.md regeneration, wrong icon library imports after merge, and case-sensitive specType comparisons.


Closes #4025

Post-script verification

  • Branch is not main/master (agent/4025-boost-agents-conventions)
  • Secret scan passed (gitleaks — 9cfc354095c029b95e030e58fd983bb316437f09..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

…S.md

Add two new sections to the boost workspace AGENTS.md to prevent
recurring CI failures and convention violations in agent-generated
PRs:

- Build & verify: command table covering build, type-check, lint,
  test, API reports, and OpenSpec validation. Includes guidance to
  run yarn build:api-reports after modifying API surface files.
- Import conventions: documents @remixicon/react as the standard
  icon library (not @mui/icons-material) and .toLowerCase()
  normalization for spec.type comparisons.

These gaps caused preventable failures on PR #3747: a missing
report.api.md regeneration, wrong icon library imports after
merge, and case-sensitive specType comparisons.

Closes #4025
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from durandom as a code owner July 28, 2026 09:19
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Agent PR ready for human review label Jul 28, 2026
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@gabemontero gabemontero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting @rohitkrai03 @johnmcollier @mareklibra @durandom I know we've added these PR pre-submit checks in (several I think) spots in our various skill locations, but the fullsend retro / coder thinks we need to add them at the workspace specific agent level as well

is this a case of directions in higher level skills falling out of the coder agent's context?

what do you all think

@gabemontero

Copy link
Copy Markdown
Contributor

interesting @rohitkrai03 @johnmcollier @mareklibra @durandom I know we've added these PR pre-submit checks in (several I think) spots in our various skill locations, but the fullsend retro / coder thinks we need to add them at the workspace specific agent level as well

is this a case of directions in higher level skills falling out of the coder agent's context?

what do you all think

yep we had a convo about that before over at https://redhat-internal.slack.com/archives/C0AR8BTMSJH/p1784229990015829 that I forgot about

@gabemontero

Copy link
Copy Markdown
Contributor

interesting @rohitkrai03 @johnmcollier @mareklibra @durandom I know we've added these PR pre-submit checks in (several I think) spots in our various skill locations, but the fullsend retro / coder thinks we need to add them at the workspace specific agent level as well
is this a case of directions in higher level skills falling out of the coder agent's context?
what do you all think

yep we had a convo about that before over at https://redhat-internal.slack.com/archives/C0AR8BTMSJH/p1784229990015829 that I forgot about

and perhaps @rohitkrai03 's change at #4023 would supersede this one then

what do we think

@mareklibra @johnmcollier @durandom FYI

@gabemontero

Copy link
Copy Markdown
Contributor

discussed in that slack thread ... we are going to wait on this PR and see if #4023 is sufficient for the coding agent remembering to perform the pre-submit PR checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold ready-for-review Agent PR ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add build commands, icon library, and specType conventions to boost workspace AGENTS.md

1 participant