Skip to content

feat: Migrate from manifest v0 to v1 format - #1239

Open
olivergondza wants to merge 6 commits into
redhat-developer:masterfrom
olivergondza:bump-opm
Open

feat: Migrate from manifest v0 to v1 format#1239
olivergondza wants to merge 6 commits into
redhat-developer:masterfrom
olivergondza:bump-opm

Conversation

@olivergondza

@olivergondza olivergondza commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Avoid using the OLMv1 and move towards OLMv2.

Co-authored-by: Cursor

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

https://redhat.atlassian.net/browse/GITOPS-10517
https://redhat.atlassian.net/browse/GITOPS-10516

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@openshift-ci openshift-ci Bot added the kind/enhancement New feature or request label Jul 28, 2026
@openshift-ci
openshift-ci Bot requested review from jannfis and jgwest July 28, 2026 11:01
@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign varshab1210 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The build now validates OLM v1 bundles, constructs file-based catalogs with OPM v1.72.0, rejects deprecated catalog images, updates bundle metadata and labels, and ignores generated catalog artifacts.

Changes

OLM v1 build and catalog migration

Layer / File(s) Summary
Bundle v1 validation and labeling
Makefile, Containerfile.plugin, bundle/bundle.Dockerfile
Bundle construction and targets now use OLM v1 labels and paths, validate the bundle schema and media type, use OPM v1.72.0, and disable app registry delivery.
File-based catalog build
Makefile, .gitignore
Catalog generation uses an FBC workflow with validation, Dockerfile generation, catalog image build and push, deprecated index.db detection, and ignores generated catalog artifacts.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Makefile
  participant opm
  participant CONTAINER_RUNTIME
  Makefile->>opm: Initialize and render file-based catalog
  Makefile->>opm: Validate catalog and generate Dockerfile
  Makefile->>CONTAINER_RUNTIME: Build catalog image
  Makefile->>CONTAINER_RUNTIME: Inspect image for index.db
Loading

Suggested reviewers: jannfis, jgwest

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: migrating bundle and catalog packaging from v0 to v1 format.
Description check ✅ Passed The description is related to the PR's OLM format migration, even if it uses broader OLMv1/OLMv2 wording.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Makefile`:
- Line 280: Update the image inspection check in the Makefile to grep for the
operators.operatorframework.io.bundle.mediatype.v1 label and assert its
registry+v1 value, replacing the current test.mediatype.v1 check so the gate
validates the bundle media type.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 06dee4f6-c341-4b6c-a565-ce25118ff839

📥 Commits

Reviewing files that changed from the base of the PR and between 4d7b223 and 0f85af1.

📒 Files selected for processing (4)
  • .gitignore
  • Containerfile.plugin
  • Makefile
  • bundle/bundle.Dockerfile
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • argoproj-labs/argocd-operator (manual)
💤 Files with no reviewable changes (1)
  • bundle/bundle.Dockerfile

Comment thread Makefile Outdated
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@olivergondza

Copy link
Copy Markdown
Collaborator Author

/retest

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@olivergondza

Copy link
Copy Markdown
Collaborator Author

/retest

@olivergondza

Copy link
Copy Markdown
Collaborator Author

@svghadi, @jgwest, can you please take a look?

This is a first step in the above Epic, addressing what I consider are the most pressing aspects before the OLMv0 deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant