feat: Migrate from manifest v0 to v1 format - #1239
Conversation
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughThe build now validates OLM v1 bundles, constructs file-based catalogs with OPM v1.72.0, rejects deprecated catalog images, updates bundle metadata and labels, and ignores generated catalog artifacts. ChangesOLM v1 build and catalog migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Makefile
participant opm
participant CONTAINER_RUNTIME
Makefile->>opm: Initialize and render file-based catalog
Makefile->>opm: Validate catalog and generate Dockerfile
Makefile->>CONTAINER_RUNTIME: Build catalog image
Makefile->>CONTAINER_RUNTIME: Inspect image for index.db
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Line 280: Update the image inspection check in the Makefile to grep for the
operators.operatorframework.io.bundle.mediatype.v1 label and assert its
registry+v1 value, replacing the current test.mediatype.v1 check so the gate
validates the bundle media type.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 06dee4f6-c341-4b6c-a565-ce25118ff839
📒 Files selected for processing (4)
.gitignoreContainerfile.pluginMakefilebundle/bundle.Dockerfile
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
argoproj-labs/argocd-operator(manual)
💤 Files with no reviewable changes (1)
- bundle/bundle.Dockerfile
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
|
/retest |
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
|
/retest |
What type of PR is this?
What does this PR do / why we need it:
Avoid using the OLMv1 and move towards OLMv2.
Co-authored-by: Cursor
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
https://redhat.atlassian.net/browse/GITOPS-10517
https://redhat.atlassian.net/browse/GITOPS-10516
Test acceptance criteria:
How to test changes / Special notes to the reviewer: