confirm: one in-hand rule for hole, densify, receive - #138
Open
rearden-grok[bot] wants to merge 2 commits into
Open
confirm: one in-hand rule for hole, densify, receive#138rearden-grok[bot] wants to merge 2 commits into
rearden-grok[bot] wants to merge 2 commits into
Conversation
take_raw deletes the BQ row, so hole= and tip-hole cover treated the loadq prefix as a fetch gap and 4-peer re-raced it. claim_ready is now confirmed ∨ matching BQ hash ∨ H ≤ lookup_taken_hi. Cover and receive use that helper; taken frames are dropped without mark_pending (no zombie loop).
api_log_records_electrum_method hit AlreadyExists on store/meta under /tmp; unrelated to have-body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After loadq
take_raw, densify skippedH ≤ lookup_taken_hibuthole=/ tip-hole cover still treated those heights as a fetch gap (BQ row is gone). Cover raced each “hole” to 4 peers; receivemark_pending’d the drop; zombie demote re-issued getdata. Host:hole>0windows issued ~391 getdata/5s vs ~76 athole=0, same confirm rate.What
One occupancy ask (
claim_ready):confirmed ∨ matching BQ hash ∨ H ≤ lookup_taken_hiHole, densify, and receive all use it. Taken frames are dropped without
mark_pending. No BQ stub rows (would inflatebq soft=nand stall after disconnect).Test