Core functional Wave E leftovers: official p2p_getdata (38 run) - #135
Merged
Conversation
Invalid GETDATA inv type 0 does not stall the session; a later MSG_BLOCK getdata of the tip is served. getmempoolinfo honors -permitbaremultisig and reports incrementalrelayfee. p2p_invalid_block stays skip at v1 magic (:44). feature_chain_tiebreaks stays skip at missing-parent B7 getdata (:86). mempool_accept stays skip at testmempoolaccept type-check dialect (:98). Q-41 is 38/267.
rearden-grok
Bot
added
the
core-functional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Official unmodified
p2p_getdata.pyisrun(37→38). Invalid GETDATA inv type 0 does not stall the session; a later MSG_BLOCK getdata of the tip is served.getmempoolinfonow honors-permitbaremultisigand reportsincrementalrelayfee.mempool_accept.pystays skip at the Core type-check dialect (:98).Official first-fails (stay skip)
p2p_invalid_block.py—--v1transportmagic-bytes mismatch (:44); v2 later missingbad-txns-inputs-duplicatefeature_chain_tiebreaks.py— missing-parent B7 getdata (:86)mempool_accept.py—testmempoolaccept(rawtxs='ff00baar')type-check string (:98)Evidence
{SCRATCH}/run-p2p_getdata.logPassedinvalid_getdata_type0_still_serves_tip_block,getmempoolinfo_permitbaremultisig_follows_ctxDo not merge unless asked.