Skip to content

Fix build-from-source on Windows: use JVM temp dir instead of hardcoded /tmp #57706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kraenhansen wants to merge 1 commit into from
+5 −2
Closed

Fix build-from-source on Windows: use JVM temp dir instead of hardcoded /tmp #57706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/react-native/settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ project(":packages:react-native:ReactAndroid:hermes-engine").projectDir =
// As we build :packages:react-native:ReactAndroid, we need to declare the folders
// for :packages and :packages:react-native as well as otherwise the build from
// source will fail with a missing folder exception.
// We point them at the JVM temp dir rather than a hardcoded "/tmp": the latter is
// not an absolute path on Windows, where Gradle would resolve it to a
// non-existing <rootDir>\tmp and fail at configuration time.

project(":packages").projectDir = file("/tmp")
project(":packages").projectDir = file(System.getProperty("java.io.tmpdir", "/tmp"))

project(":packages:react-native").projectDir = file("/tmp")
project(":packages:react-native").projectDir = file(System.getProperty("java.io.tmpdir", "/tmp"))
Loading