RDKEMW-18230: Create vdevice manifest with middleware compontents#28
Open
agampa263 wants to merge 4 commits into
Open
RDKEMW-18230: Create vdevice manifest with middleware compontents#28agampa263 wants to merge 4 commits into
agampa263 wants to merge 4 commits into
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Yocto setup-environment bootstrap script to support vdevice builds by optionally using a product-layer-provided local.conf.sample as the initial conf/local.conf.
Changes:
- Detect vdevice product layers and locate a
conf/template/local.conf.sampleto use as a customlocal.conftemplate. - When generating a new build directory config, copy the vdevice
local.conf.sampleintoconf/local.conf. - Ensure the new temporary variable is cleaned up at script end (but currently misses cleanup on the early-return path).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+129
to
+133
| #add this change to build vdevice and changes will apply only for vdevice | ||
| _CUSTOM_LOCALCONF= | ||
| if [[ "${MANIFEST_PATH_PRODUCT_LAYER}" == *"vdevice"* ]] && [ -f "${MANIFEST_PATH_PRODUCT_LAYER}/conf/template/local.conf.sample" ]; then | ||
| _CUSTOM_LOCALCONF="${MANIFEST_PATH_PRODUCT_LAYER}/conf/template/local.conf.sample" | ||
| fi |
| mv ${_PWD_PREV}/../manifest_vars.conf ${_BUILDDIR}/conf/manifest_vars.conf | ||
| fi | ||
|
|
||
| #add this change to build vdevice and changes will apply only for vdevice |
| return 0 | ||
| fi | ||
|
|
||
| #add this change to build vdevice and changes will apply only for vdevice |
Comment on lines
+129
to
+133
| #add this change to build vdevice and changes will apply only for vdevice | ||
| _CUSTOM_LOCALCONF= | ||
| if [[ "${MANIFEST_PATH_PRODUCT_LAYER}" == *"vdevice"* ]] && [ -f "${MANIFEST_PATH_PRODUCT_LAYER}/conf/template/local.conf.sample" ]; then | ||
| _CUSTOM_LOCALCONF="${MANIFEST_PATH_PRODUCT_LAYER}/conf/template/local.conf.sample" | ||
| fi |
| mv ${_PWD_PREV}/../manifest_vars.conf ${_BUILDDIR}/conf/manifest_vars.conf | ||
| fi | ||
|
|
||
| #add this change to build vdevice and changes will apply only for vdevice |
| return 0 | ||
| fi | ||
|
|
||
| #add this change to build vdevice and changes will apply only for vdevice |
| # instead of the default TEMPLATECONF template. Other product layers continue to use default behavior. | ||
| # This allows vdevice-specific configurations to be maintained in the product layer itself. | ||
|
|
||
| if [[ "${MANIFEST_PATH_PRODUCT_LAYER}" == *"vdevice"* ]] && [ -f "${MANIFEST_PATH_PRODUCT_LAYER}/conf/template/local.conf.sample" ]; then |
sync with develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Create vdevice manifest with middleware compontents
Test Procedure: verify the builds are passed without any failures
Risks: Low
version: minor
Priority: P1
Signed-off-by:AkshayKumar_Gampa AkshayKumar_Gampa@comcast.com