fix(frontier): default billing refresh intervals to frontier defaults instead of disabling sync#141
Conversation
… instead of disabling sync
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request updates the Compact metadata:
Related issues: None specified Related PRs: None specified Suggested labels: helm-chart, configuration, documentation Suggested reviewers: None specified Poem: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The frontier chart sets four billing refresh interval env vars to
0onfrontier-app:An interval of
0disables that background sync job entirely. Forinvoicethis also disables monthly credit overdraft invoice generation.Today these var names are not read by frontier:
billingis a top-level config key (not underapp), and since frontier v0.100.0 (raystack/frontier#1332) the env prefix isFRONTIER_SERVICE_. So frontier silently runs on its built-in defaults. But the chart's stated default is still "disable all billing sync", and if the env var naming is ever aligned with frontier's config, deployments that do not run the worker would silently stop generating invoices.Change
0to frontier's built-in defaults:1mfor customer/subscription/checkout,5mfor invoice, so the chart's stated defaults match frontier's actual behavior.FRONTIER_APP_prefix for consistency with the rest of the chart's config keys; aligning names with frontier's current env binding can be done separately.helm lint stable/frontierpasses (pre-existing warnings about missing subchart deps and icon only).