Raise property-testing-testo to ^0.4 - #26
Merged
Merged
Conversation
The adapter chains to the engine by minor: -testo 0.3 requires core ^0.3, so a ^0.1 pin installs core 0.1 and leaves every 0.2/0.3 engine feature — Gen::swarm, Gen::forClass, Gen::regex, edgeCases, the distribution report, shrink-path replay — unreachable. This package was pinned there. The three generator methods in QueryBuildingVisitorTest were `private function`, reached only by reflection. Rector's RemoveUnusedPrivateMethodRector sees no call site and deletes them; they are `public static` now, the convention this monorepo already documents. RemoveUselessVarTagRector is skipped with the reason in rector.php: it strips the `@var mixed` psalm requires on an assignment from a mixed-returning call. No test change beyond the promotion. The composition-law suite already carries Examples() over an operand catalogue, which is the reference the rest of this migration has been copying.
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
rasuvaeff/property-testing-testo: ^0.1^0.4rasuvaeff/rector-named-literalsprivate→public staticWhy the pin had to move
The adapter chains to the engine by minor —
-testo 0.3requirescore ^0.3—so a
^0.1pin installs core 0.1 and leaves every 0.2/0.3 engine featureunreachable:
Gen::swarm,Gen::forClass,Gen::regex,edgeCases, thedistribution report, shrink-path replay.
Three generators were one rector run from deletion
QueryBuildingVisitorTesthadprivate function <method>Generators(), invokedonly by reflection.
RemoveUnusedPrivateMethodRectorsees no call site andremoves them; the properties would then run with no generators at all.
One rector rule skipped
RemoveUselessVarTagRectorstrips the@var mixedpsalm requires on anassignment from a mixed-returning call; psalm reports
MixedAssignmentwithoutit. The documented rector↔psalm conflict, resolved the same way as in
media-converter.No test change beyond the promotion, deliberately
CompositionLawsPropertyTestalready carriesExamples()over an operandcatalogue — it is the reference the rest of this migration has been copying.
Going through the checklist:
Gen::swarmneedsGen::commands, and aspecification is composed then evaluated, with no lifecycle;
Gen::forClasscannot construct specifications, which validate operators and identifiers in
their constructors; nothing generated is dated, binary or UUID-shaped.
Verification
composer buildgreen locally.