Migrate to property-testing-testo and enable regression corpus in CI - #24
Merged
Conversation
Switch from the frozen rasuvaeff/property-testing:^2.6 to the split rasuvaeff/property-testing-testo:^0.1 adapter (issue-first per TESTING-STRENGTHENING-PLAN.md §3.1). Add the three-step corpus pipeline (restore / PROPERTY_DB env / save) to the coverage job, mirroring the pattern landed in clickhouse-toolkit PR #27. Locally verified the full corpus cycle: a deliberately falsified CompositionLawsPropertyTest::andIsCommutative persisted a minimised seed to build/property-db, the next run replayed it and failed, and after reverting the falsification the corpus entry was auto-dropped on a green replay. Fixes #23
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR replaces the frozen property-testing package with ChangesProperty testing corpus
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23.
What
Local verification (full corpus cycle)
Why split restore/save
A combined `actions/cache` declares `post-if: success()` — on a red property run the corpus is never saved, which is precisely the case that produces a new counterexample. `save` with `if: ${{ !cancelled() }}` persists the corpus even when `test:coverage:ci` exits non-zero. `run_attempt` is in the key so a re-run (same `run_id`) writes a fresh key instead of hitting `Cache already exists`.
Acceptance
Summary by CodeRabbit
Tests
Chores