Include query string in req_dry_run() output - #869
Open
wikisqueaks wants to merge 1 commit into
Open
Conversation
`curl::curl_echo()` splits the request into separate `path` and `query` fields, but only `path` was used, so the printed request line and the returned list both omitted the query. The httr2 1.0.0 blog post shows `HEAD /?param=value HTTP/1.1`, so this appears to be a regression. Fixes r-lib#868.
Author
|
The failing check is a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curl::curl_echo()splits the request into separatepathandqueryfields, but only
pathwas used, so the printed request line and thereturned list both omitted the query. The httr2 1.0.0 blog post shows
HEAD /?param=value HTTP/1.1, so this appears to be a regression.queryis returned verbatim, including the leading?that httpuv putsin
QUERY_STRING— happy to strip it if you'd rather it matchedpath.Existing snapshots are unchanged, since they all use query-less URLs.
Fixes #868.