Skip to content

Include query string in req_dry_run() output - #869

Open
wikisqueaks wants to merge 1 commit into
r-lib:mainfrom
wikisqueaks:dry-run-query
Open

Include query string in req_dry_run() output#869
wikisqueaks wants to merge 1 commit into
r-lib:mainfrom
wikisqueaks:dry-run-query

Conversation

@wikisqueaks

Copy link
Copy Markdown

curl::curl_echo() splits the request into separate path and query
fields, but only path was used, so the printed request line and the
returned list both omitted the query. The httr2 1.0.0 blog post shows
HEAD /?param=value HTTP/1.1, so this appears to be a regression.

query is returned verbatim, including the leading ? that httpuv puts
in QUERY_STRING — happy to strip it if you'd rather it matched path.

Existing snapshots are unchanged, since they all use query-less URLs.

Fixes #868.

`curl::curl_echo()` splits the request into separate `path` and `query`
fields, but only `path` was used, so the printed request line and the
returned list both omitted the query. The httr2 1.0.0 blog post shows
`HEAD /?param=value HTTP/1.1`, so this appears to be a regression.

Fixes r-lib#868.
@wikisqueaks

Copy link
Copy Markdown
Author

The failing check is a pull_request_target workflow that can't check out fork code under the new actions/checkout default. It won't affect PRs from branches in the repo, only forks. R-CMD-check passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

req_dry_run() omits the query string from its output

1 participant