Iterator.contact fixes - #1623
Merged
Merged
Conversation
saghul
commented
Jul 31, 2026
saghul
commented
Contributor
- Complete the concat iterator when the value getter throws
- Do not forward Iterator.concat().return() to a completed iterator
js_iterator_concat_next() reached the `fail:` label, which marks the iterator done, for every step failure but one: a throwing `value` getter went straight to `done:` with a pending exception, leaving the iterator suspended. A second next() then stepped the underlying iterator again and threw again, where the spec has the generator completed and returns an undefined, done result. Fixes a case missed by "Fix the throw paths of the iterator helpers".
js_iterator_concat_return() ran IteratorClose whenever an iterator was still open, including after an abrupt completion had already finished the generator. The spec has %IteratorHelperPrototype%.return go through GeneratorResumeAbrupt, which returns an undefined, done result right away for a completed generator, without closing anything: after next() throws, return() must not reach the underlying iterator. Also mark the iterator done in return() itself, so that the state is explicit rather than implied by the drained list of iterables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.