Skip to content

Detect whitespace#486

Open
azharsha wants to merge 2 commits into
qualcomm-linux:mainfrom
azharsha:whitespace
Open

Detect whitespace#486
azharsha wants to merge 2 commits into
qualcomm-linux:mainfrom
azharsha:whitespace

Conversation

@azharsha

@azharsha azharsha commented Jun 8, 2026

Copy link
Copy Markdown

No description provided.

@smuppand smuppand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Move git diff --check into the existing Shell Lint/Preflight workflow.
  • Keep it pull_request-focused.
  • Split repository-wide whitespace cleanup into a separate mechanical PR only if maintainers want it.

- name: Check for trailing whitespace
run: |
set -eu
git diff --check origin/main...HEAD \

@smuppand smuppand Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK

@azharsha

azharsha commented Jun 9, 2026

Copy link
Copy Markdown
Author
  • Move git diff --check into the existing Shell Lint/Preflight workflow.
  • Keep it pull_request-focused.
    ACK
  • Split repository-wide whitespace cleanup into a separate mechanical PR only if maintainers want it.
    Why would maintainers not want to remove whitespace cleanup? As mentioned in the commit message, there is no functional change attached with the cleanup. Please list the maintainers I will add them to this PR.

azharsha added 2 commits June 9, 2026 11:23
No functional code change in this commit.
This one only removes all trailing white spaces.

Signed-off-by: Azhar Shaikh <azhashai@qti.qualcomm.com>
Add a pre-merge check to detect any whitespace and fail the
pre-merge if any detected.

Signed-off-by: Azhar Shaikh <azhashai@qti.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants