Skip to content

FROMLIST: Revert "wifi: ath12k: add panic handler"#1357

Merged
miaoqing-quic merged 1 commit into
qualcomm-linux:tech/net/athfrom
MilanoPipo:ath-new4
Jun 15, 2026
Merged

FROMLIST: Revert "wifi: ath12k: add panic handler"#1357
miaoqing-quic merged 1 commit into
qualcomm-linux:tech/net/athfrom
MilanoPipo:ath-new4

Conversation

@MilanoPipo

Copy link
Copy Markdown
Contributor

This reverts commit 8090556.

Call trace:
rcu_note_context_switch+0x4c4/0x508 (P)
__schedule+0xbc/0x1204
schedule+0x34/0x110
schedule_timeout+0x84/0x11c
__mhi_device_get_sync+0x164/0x228 [mhi]
mhi_device_get_sync+0x1c/0x3c [mhi]
ath12k_wifi7_pci_bus_wake_up+0x20/0x2c [ath12k_wifi7] ath12k_pci_read32+0x58/0x350 [ath12k]
ath12k_pci_clear_dbg_registers+0x28/0xb8 [ath12k]
ath12k_pci_panic_handler+0x20/0x44 [ath12k] ath12k_core_panic_handler+0x28/0x3c [ath12k] notifier_call_chain+0x78/0x1c0
atomic_notifier_call_chain+0x3c/0x5c

ath12k_core_panic_handler() is invoked via atomic_notifier_call_chain(), which runs inside an RCU read-side critical section. The current code calls ath12k_pci_sw_reset() synchronously from this context, which eventually reaches mhi_device_get_sync() and schedule_timeout(), triggering a voluntary context switch within RCU.

Revert change "wifi: ath12k: add panic handler" to avoid this issue.

Tested-on: WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
Link: https://lore.kernel.org/all/20260612032332.2278338-1-yingying.tang@oss.qualcomm.com/
CRs-Fixed: 4390354

This reverts commit 8090556.

Call trace:
rcu_note_context_switch+0x4c4/0x508 (P)
__schedule+0xbc/0x1204
schedule+0x34/0x110
schedule_timeout+0x84/0x11c
__mhi_device_get_sync+0x164/0x228 [mhi]
mhi_device_get_sync+0x1c/0x3c [mhi]
ath12k_wifi7_pci_bus_wake_up+0x20/0x2c [ath12k_wifi7]
ath12k_pci_read32+0x58/0x350 [ath12k]
ath12k_pci_clear_dbg_registers+0x28/0xb8 [ath12k]
ath12k_pci_panic_handler+0x20/0x44 [ath12k] ath12k_core_panic_handler+0x28/0x3c [ath12k]
notifier_call_chain+0x78/0x1c0
atomic_notifier_call_chain+0x3c/0x5c

ath12k_core_panic_handler() is invoked via atomic_notifier_call_chain(),
which runs inside an RCU read-side critical section. The current code calls
ath12k_pci_sw_reset() synchronously from this context, which eventually
reaches mhi_device_get_sync() and schedule_timeout(), triggering a voluntary
context switch within RCU.

Revert change "wifi: ath12k: add panic handler" to avoid this issue.

Tested-on: WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
Link: https://lore.kernel.org/all/20260612032332.2278338-1-yingying.tang@oss.qualcomm.com/
Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team and miaoqing-quic and removed request for a team June 12, 2026 08:40
@qlijarvis

Copy link
Copy Markdown

PR #1357 — validate-patch

PR: #1357

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: Yes — Link tag points to https://lore.kernel.org/all/20260612032332.2278338-1-yingying.tang@oss.qualcomm.com/
  2. Lore link matches PR commits: Cannot verify — network access to lore.kernel.org is restricted; unable to fetch upstream patch for comparison
  3. Upstream patch status: In review — FROMLIST prefix indicates patch posted to mailing list but not yet merged; message-ID timestamp (2026-06-12) suggests very recent submission
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints; FROMLIST patches are typically not in qcom-next until upstream acceptance
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1357 - Revert "wifi: ath12k: add panic handler"
Upstream commit: https://lore.kernel.org/all/20260612032332.2278338-1-yingying.tang@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - lore.kernel.org unreachable; FROMLIST prefix present
Body preserves rationale Clear explanation with call trace and RCU context issue
Fixes tag present/correct Missing Fixes tag; should reference 8090556 ("wifi: ath12k: add panic handler")
Authorship preserved Author: Yingying Tang yingying.tang@oss.qualcomm.com
Backport note (if applicable) N/A FROMLIST indicates pending upstream submission

Diff

File Status Notes
drivers/net/wireless/ath/ath12k/core.c Removes panic_handler registration/unregistration (33 lines)
drivers/net/wireless/ath/ath12k/core.h Removes panic_notifier.h include and panic_nb field (3 lines)
drivers/net/wireless/ath/ath12k/hif.h Removes panic_handler ops and wrapper (9 lines)
drivers/net/wireless/ath/ath12k/pci.c Removes ath12k_pci_panic_handler implementation (8 lines)

Issues

  • Missing Fixes tag: Revert commits should include Fixes: 809055628bce ("wifi: ath12k: add panic handler") to identify the commit being reverted
  • Cannot verify upstream match: Network restrictions prevent fetching the lore.kernel.org patch for comparison; the Link tag points to a message-ID dated 2026-06-12 (today), suggesting this is a very recent or future submission

Verdict

Patch structure and rationale are sound; add Fixes tag before merging.

Final Summary

  1. Lore link present: Yes — Link tag points to https://lore.kernel.org/all/20260612032332.2278338-1-yingying.tang@oss.qualcomm.com/
  2. Lore link matches PR commits: Cannot verify — network access to lore.kernel.org is restricted; unable to fetch upstream patch for comparison
  3. Upstream patch status: In review — FROMLIST prefix indicates patch posted to mailing list but not yet merged; message-ID timestamp (2026-06-12) suggests very recent submission
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints; FROMLIST patches are typically not in qcom-next until upstream acceptance

@qlijarvis

Copy link
Copy Markdown

PR #1357 — checker-log-analyzer

PR: #1357
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27404819951

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ 1 warning: commit message line exceeds 75 chars
dt-binding-check ⏭️ Skipped - no DT binding changes
dtb-check ⏭️ Skipped - no devicetree changes
sparse-check Passed - sparse not available warning is expected
check-uapi-headers Passed - no UAPI header changes
check-patch-compliance Passed - FROMLIST prefix validated
tag-check Missing - job did not run
qcom-next-check Missing - job did not run

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: FROMLIST: Revert "wifi: ath12k: add panic handler" (#1357)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27404819951

Checker Result Summary
checkpatch ⚠️ 1 warning: commit message line exceeds 75 chars
dt-binding-check ⏭️ Skipped - no DT binding changes
dtb-check ⏭️ Skipped - no devicetree changes
sparse-check Passed - sparse not available warning is expected
check-uapi-headers Passed - no UAPI header changes
check-patch-compliance Passed - FROMLIST prefix validated
tag-check Missing - job did not run
qcom-next-check Missing - job did not run

❌ Workflow Failure: Missing Required Checker Jobs

Root cause: The CI workflow failed because two required checker jobs (tag-check and qcom-next-check) did not execute or produce logs.

Failure details:

2026-06-12T09:15:52.8752551Z state="failure"
2026-06-12T09:15:52.8753110Z desc="Workflow failed"

The workflow directory name pr1357_no_jobs_20260612_092926 indicates that some jobs failed to run. Only 6 of the expected 8 checker jobs produced logs:

  • ✅ Present: checkpatch, dt-binding-check, dtb-check, sparse-check, check-uapi-headers, check-patch-compliance
  • ❌ Missing: tag-check, qcom-next-check

Fix:

  1. Re-trigger the CI workflow to ensure all checker jobs execute
  2. If the issue persists, investigate the GitHub Actions workflow configuration for job dependencies or runner availability issues
  3. The tag-check and qcom-next-check jobs may have failed to start due to workflow orchestration issues

Reproduce locally:
The missing jobs cannot be reproduced locally as they didn't execute. However, you can validate the patch content manually:

# Verify FROMLIST prefix is present
git log --oneline -1 1ef96214f7065f54ae76a8ee6f001d479647d471

# Check for proper subject prefix
git show --format=%s 1ef96214f7065f54ae76a8ee6f001d479647d471

⚠️ checkpatch

Root cause: Commit message line 18 exceeds the recommended 75 character limit.

Failure details:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#18: 
ath12k_pci_panic_handler+0x20/0x44 [ath12k] ath12k_core_panic_handler+0x28/0x3c [ath12k]

1ef96214f7065f54ae76a8ee6f001d479647d471 total: 0 errors, 1 warnings, 0 checks, 119 lines checked

Fix:
This is a call trace line in the commit message that documents the bug being fixed. This warning can typically be ignored for call traces, as they should not be reformatted. However, if you want to address it, you could wrap the line:

ath12k_pci_panic_handler+0x20/0x44 [ath12k]
ath12k_core_panic_handler+0x28/0x3c [ath12k]

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git d3a80a26bb9db22266d6a1bab5ad61e3925453d2..95e801cb5c538b2d161579d57e9351bdf01e2752

Verdict

2 blockers to fix: The workflow failed due to missing required checker jobs (tag-check and qcom-next-check). The checkpatch warning is non-blocking as it's a call trace in the commit message. Action required: Re-trigger the CI workflow to ensure all checker jobs execute successfully.

@miaoqing-quic miaoqing-quic merged commit 1c90555 into qualcomm-linux:tech/net/ath Jun 15, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants