Skip to content

FROMLIST: arm64: dts: qcom: glymur-crd: Add FocalTech ft3d81 touchscr…#1328

Open
pradyot7 wants to merge 1 commit into
qualcomm-linux:tech/all/dt/glymurfrom
pradyot7:glymur-touchscreen
Open

FROMLIST: arm64: dts: qcom: glymur-crd: Add FocalTech ft3d81 touchscr…#1328
pradyot7 wants to merge 1 commit into
qualcomm-linux:tech/all/dt/glymurfrom
pradyot7:glymur-touchscreen

Conversation

@pradyot7

@pradyot7 pradyot7 commented Jun 8, 2026

Copy link
Copy Markdown

…een support

The touchscreen module on Glymur/Mahua CRDs is different from the one used on Hamoa CRDs and requires the reset-gpios to be wired to the device. Without this in place the reset line will remain permanently asserted during resume leaving the device offline and causing all I2C transactions to fail with -ENXIO.

i2c_hid_of 3-0038: failed to change power setting. i2c_hid_of 3-0038: PM: dpm_run_callback():
i2c_hid_core_pm_resume [i2c_hid] returns -6
i2c_hid_of 3-0038: PM: failed to resume async: error -6

The touchscreen on Glymur/Mahua-CRD is a focaltech ft3d81, which is hardware-compatible with the ft8112.
we have added the required change in DT.

Fixes: e6bf559 ("arm64: dts: qcom: glymur-crd: Enable keyboard, trackpad and touchscreen")

Link: https://lore.kernel.org/linux-arm-msm/20260603-arm64-dts-glymur-crd-add-reset-gpio-to-v3-2-3453ef577bcf@oss.qualcomm.com/

…een support

The touchscreen module on Glymur/Mahua CRDs is different from
the one used on Hamoa CRDs and requires the reset-gpios to be wired to
the device. Without this in place the reset line will remain
permanently asserted during resume leaving the device offline and causing
all I2C transactions to fail with -ENXIO.

i2c_hid_of 3-0038: failed to change power setting.
i2c_hid_of 3-0038: PM: dpm_run_callback():
i2c_hid_core_pm_resume [i2c_hid] returns -6
i2c_hid_of 3-0038: PM: failed to resume async: error -6

The touchscreen on Glymur/Mahua-CRD is a focaltech ft3d81,
which is hardware-compatible with the ft8112.
we have added the required change in DT.

Fixes: e6bf559 ("arm64: dts: qcom: glymur-crd: Enable keyboard, trackpad and touchscreen")

Link: https://lore.kernel.org/linux-arm-msm/20260603-arm64-dts-glymur-crd-add-reset-gpio-to-v3-2-3453ef577bcf@oss.qualcomm.com/
Signed-off-by: Pradyot Kumar Nayak <pradyot.nayak@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team, rrnayak, sgaud-quic and yijiyang and removed request for a team June 8, 2026 17:37
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1328

PR: #1328
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27155686900

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during automerge arch/arm64/configs/defconfig No Pre-existing merge conflict between the PR's topic branch (topic/tech/all/dt/glymur) and the baseline integration branch. The conflict is in defconfig, but the PR only modifies glymur-crd.dtsi.

Verdict

This is not a compilation error. The build failed during the pre-merge integration phase due to a merge conflict in arch/arm64/configs/defconfig. The PR itself only modifies arch/arm64/boot/dts/qcom/glymur-crd.dtsi and does not introduce any compilation errors. The conflict is a pre-existing integration issue unrelated to the PR's changes.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1328

PR: #1328
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27155686900

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during topic branch integration arch/arm64/configs/defconfig No Pre-existing conflict between topic branch and baseline; PR only modifies glymur-crd.dtsi

Verdict

This is NOT a compilation failure. The build failed during the merge/integration phase due to a pre-existing merge conflict in arch/arm64/configs/defconfig. The PR does not introduce this issue—it only modifies arch/arm64/boot/dts/qcom/glymur-crd.dtsi.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1328 — validate-patch

PR: #1328

Verdict Issues Detailed Report
⚠️ 4 Full report

Final Summary

  1. Lore link present: Yes — Link: tag points to https://lore.kernel.org/linux-arm-msm/20260603-arm64-dts-glymur-crd-add-reset-gpio-to-v3-2-3453ef577bcf@oss.qualcomm.com/
  2. Lore link matches PR commits: Cannot verify — network access restricted; lore.kernel.org unreachable during validation
  3. Upstream patch status: In review — FROMLIST prefix indicates patch posted to mailing list but not yet merged; message-ID format suggests v3 revision (20260603-...-v3-2-...)
  4. PR present in qcom-next: Not checked — no kernel source tree available per task constraints

Recommendation: Request upstream comparison when network access is available. Address commit message style issues (capitalization, imperative mood). Clarify why commit message mentions reset-gpios but diff only changes compatible string — if this is part of a series, the commit message should reference the companion patch.

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1328 - arm64: dts: qcom: glymur-crd: Add FocalTech ft3d81 touchscreen support
Upstream commit: https://lore.kernel.org/linux-arm-msm/20260603-arm64-dts-glymur-crd-add-reset-gpio-to-v3-2-3453ef577bcf@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - network restricted; lore.kernel.org unreachable
Body preserves rationale Clear problem statement with error logs and hardware explanation
Fixes tag present/correct Fixes: e6bf559 properly formatted with subject line
Authorship preserved Author: Pradyot Kumar Nayak pradyot.nayak@oss.qualcomm.com
Backport note (if applicable) N/A FROMLIST prefix indicates pending upstream submission

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur-crd.dtsi:789 Single-line compatible string update: adds ft3d81 as primary, keeps ft8112 fallback

Issues

  • Capitalization inconsistency: Line "we have added the required change in DT." starts with lowercase "we" — should be "We have added..." or better yet, use imperative mood: "Add the required change in DT."
  • Commit message style: The phrase "we have added" uses past tense; kernel convention prefers imperative mood (e.g., "Add ft3d81 compatible string...")
  • Subject line clarity: The subject mentions "Add FocalTech ft3d81 touchscreen support" but the actual change only adds a compatible string, not full device support (no new node, just compatible update)
  • Commit message disconnect: The body mentions "requires the reset-gpios to be wired to the device" but the diff shows no reset-gpios addition — only a compatible string change. This suggests either:
    1. The commit message describes a different/larger change than what's in the diff, or
    2. This is patch 2/N of a series where patch 1 added reset-gpios

Verdict

Cannot fully validate without upstream comparison due to network restrictions. The patch has good structure (proper Fixes tag, Link tag, clear error logs) but exhibits commit message style issues (capitalization, tense) and a potential mismatch between the commit message description (mentions reset-gpios wiring) and the actual diff (only compatible string change).

Final Summary

  1. Lore link present: Yes — Link: tag points to https://lore.kernel.org/linux-arm-msm/20260603-arm64-dts-glymur-crd-add-reset-gpio-to-v3-2-3453ef577bcf@oss.qualcomm.com/
  2. Lore link matches PR commits: Cannot verify — network access restricted; lore.kernel.org unreachable during validation
  3. Upstream patch status: In review — FROMLIST prefix indicates patch posted to mailing list but not yet merged; message-ID format suggests v3 revision (20260603-...-v3-2-...)
  4. PR present in qcom-next: Not checked — no kernel source tree available per task constraints

Recommendation: Request upstream comparison when network access is available. Address commit message style issues (capitalization, imperative mood). Clarify why commit message mentions reset-gpios but diff only changes compatible string — if this is part of a series, the commit message should reference the companion patch.

@qlijarvis

Copy link
Copy Markdown

PR #1328 — checker-log-analyzer

PR: #1328
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27155687119

Checker Result Summary
Checker Result Summary
checkpatch Merge conflict in arch/arm64/configs/defconfig
dt-binding-check Merge conflict in arch/arm64/configs/defconfig
dtb-check Merge conflict in arch/arm64/configs/defconfig
sparse-check Merge conflict in arch/arm64/configs/defconfig
check-uapi-headers Merge conflict in arch/arm64/configs/defconfig
check-patch-compliance Merge conflict in arch/arm64/configs/defconfig
tag-check N/A Not applicable for topic branches
qcom-next-check ⏭️ FROMLIST: prefix present (correct)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1328 - FROMLIST: arm64: dts: qcom: glymur-crd: Add FocalTech ft3d81 touchscreen support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27155687119

Checker Result Summary
checkpatch Merge conflict in arch/arm64/configs/defconfig
dt-binding-check Merge conflict in arch/arm64/configs/defconfig
dtb-check Merge conflict in arch/arm64/configs/defconfig
sparse-check Merge conflict in arch/arm64/configs/defconfig
check-uapi-headers Merge conflict in arch/arm64/configs/defconfig
check-patch-compliance Merge conflict in arch/arm64/configs/defconfig
tag-check N/A Not applicable for topic branches
qcom-next-check ⏭️ FROMLIST: prefix present (correct)

❌ All Checkers Failed Due to Merge Conflict

Root cause: The CI workflow failed during the automerge phase when attempting to merge the topic branch tech/all/dt/glymur into the integration baseline. A merge conflict occurred in arch/arm64/configs/defconfig.

Failure details:

2026-06-08T18:07:14.0741014Z Auto-merging arch/arm64/configs/defconfig
2026-06-08T18:07:14.0741631Z CONFLICT (content): Merge conflict in arch/arm64/configs/defconfig
2026-06-08T18:07:14.1379834Z Automatic merge failed; fix conflicts and then commit the result.
2026-06-08T18:07:14.1509935Z Merge failed, manual merge

Analysis:

  • This PR modifies only arch/arm64/boot/dts/qcom/glymur-crd.dtsi (a device tree file)
  • The merge conflict is in arch/arm64/configs/defconfig (a kernel config file)
  • The conflict is NOT caused by this PR's changes — it's a pre-existing conflict in the base branch tech/all/dt/glymur
  • All six checkers failed at the same point: during the initial automerge setup, before any actual checker validation could run
  • None of the checkers (checkpatch, dt-binding-check, dtb-check, sparse-check, check-uapi-headers, check-patch-compliance) were able to execute their actual validation logic

Fix:

This is not a problem with the PR itself. The issue is with the base branch tech/all/dt/glymur having a merge conflict with the integration baseline.

Option 1: Resolve the base branch conflict (Recommended)
The maintainer of tech/all/dt/glymur needs to:

  1. Rebase or merge the topic branch against the latest integration baseline
  2. Resolve the conflict in arch/arm64/configs/defconfig
  3. Push the updated topic branch

Option 2: Test the PR in isolation
To verify this PR's changes are valid:

# Clone the kernel repo
git clone https://github.com/qualcomm-linux/kernel.git
cd kernel

# Fetch and checkout the PR
git fetch origin pull/1328/head:pr-1328
git checkout pr-1328

# Run checkpatch on just this commit
git show HEAD | ./scripts/checkpatch.pl --no-tree -

# Build device tree to check for DT errors
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- dtbs

Reproduce locally:

cd /path/to/kernel
git fetch https://github.com/qualcomm-linux/kernel-topics.git tech/all/dt/glymur
git checkout -b test-merge <integration-baseline-sha>
git merge FETCH_HEAD
# You will see the same conflict in arch/arm64/configs/defconfig

Verdict

This PR cannot be validated by CI until the base branch tech/all/dt/glymur resolves its merge conflict with the integration baseline. The PR's actual changes (adding "focaltech,ft3d81" compatible string to the touchscreen node) appear valid and follow proper device tree conventions. The failure is infrastructure-related, not code-related.

Action required: Topic branch maintainer must resolve the arch/arm64/configs/defconfig conflict in tech/all/dt/glymur before this PR can be properly validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants