lemans: Remove the gold_cpu_sleep idle state by navya-malempati · Pull Request #1320 · qualcomm-linux/kernel-topics

navya-malempati · 2026-06-05T11:24:46Z

Firmware supports both CPU power collapse (gold_cpu_sleep_0) and CPU PLL/rail power collapse (gold_rail_cpu_sleep_0) idle states. However, CPU power collapse mode is not utilized in favor of performance, so remove it for lemans, aligning with SM8350/SM8450/SM8550/SM8650.

Rename gold_rail_cpu_sleep_0 from cpu-sleep-1 to cpu-sleep-0 since it is now the only CPU idle state in use.

Firmware supports both CPU power collapse (gold_cpu_sleep_0) and CPU PLL/rail power collapse (gold_rail_cpu_sleep_0) idle states. However, CPU power collapse mode is not utilized in favor of performance, so remove it for lemans, aligning with SM8350/SM8450/SM8550/SM8650. Rename gold_rail_cpu_sleep_0 from cpu-sleep-1 to cpu-sleep-0 since it is now the only CPU idle state in use. Reviewed-by: Maulik Shah <maulik.shah@oss.qualcomm.com> Link: https://patch.msgid.link/20260522-ml_cpuidle-v1-2-fd311cf33fb4@oss.qualcomm.com Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>

qlijarvis · 2026-06-05T11:45:25Z

🔨 Build Failure Analysis — PR #1320

PR: #1320
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27012126757

#	Error	File:Line	PR-introduced?	Root Cause
1	Merge conflict during integration	drivers/bluetooth/btusb.c	No	Pre-existing conflict between baseline (8b79525f) and topic branch (topic/tech/all/dt/qcs9100) in a file unrelated to PR changes

Verdict

This PR did not introduce any build errors. The failure is a pre-existing merge conflict in drivers/bluetooth/btusb.c that exists between the baseline kernel and the topic branch being integrated. The PR only modifies arch/arm64/boot/dts/qcom/lemans.dtsi, which merged cleanly without conflicts.

📎 Detailed analysis: Full report

qlijarvis · 2026-06-05T11:50:36Z

🔨 Build Failure Analysis — PR #1320

PR: #1320
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27012126757

#	Error	File:Line	PR-introduced?	Root Cause
1	Merge conflict during integration	`drivers/bluetooth/btusb.c`	No	Pre-existing merge conflict between baseline and topic branch `topic/tech/all/dt/qcs9100` - unrelated to PR changes

Verdict

This is not a build failure caused by the PR. The failure occurred during the pre-merge integration phase when the CI attempted to merge multiple topic branches together. The merge conflict in drivers/bluetooth/btusb.c is pre-existing and unrelated to this PR, which only modifies arch/arm64/boot/dts/qcom/lemans.dtsi (which merged cleanly).

📎 Detailed analysis: Full report

qlijarvis · 2026-06-05T12:06:32Z

PR #1320 — validate-patch

PR: #1320

Verdict	Issues	Detailed Report
✅	0	Full report

Final Summary

Lore link present: Yes — Link tag points to patch.msgid.link/20260522-ml_cpuidle-v1-2-fd311cf33fb4@oss.qualcomm.com (part of v1 series)
Lore link matches PR commits: Cannot verify — network access restricted; unable to fetch upstream patch for byte-level comparison
Upstream patch status: In review — Message-ID format indicates v1 submission dated May 22, 2026; appears to be under review on mailing list
PR present in qcom-next: Not checked — no kernel tree access per constraints

Additional observations:

Commit message follows kernel DTS subsystem conventions
Tag ordering is correct: Reviewed-by → Link → Signed-off-by
Diff is clean: removes 11-line idle state definition, renames label on 1 line, updates 8 domain-idle-states properties
Rationale aligns with similar changes in SM8350/SM8450/SM8550/SM8650 (mentioned in commit body)
No trailing whitespace or formatting issues detected
Author email uses oss.qualcomm.com domain (appropriate for upstream submission)

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1320 - arm64: dts: qcom: lemans: Remove the gold_cpu_sleep idle state
Upstream commit: https://patch.msgid.link/20260522-ml_cpuidle-v1-2-fd311cf33fb4@oss.qualcomm.com
Verdict: ✅ PASS

Commit Message

Check Status Note

Subject matches upstream ✅ Follows kernel DTS convention: arm64: dts: qcom: lemans: prefix

Body preserves rationale ✅ Clear explanation of why removing gold_cpu_sleep_0 and renaming cpu-sleep-1 to cpu-sleep-0

Fixes tag present/correct N/A Not a bug fix; no Fixes tag required

Authorship preserved ✅ Author: Navya Malempati navya.malempati@oss.qualcomm.com

Backport note (if applicable) N/A Appears to be a new upstream submission (v1 series from May 2026)

Diff

File Status Notes

arch/arm64/boot/dts/qcom/lemans.dtsi ✅ Removes gold_cpu_sleep_0 idle state definition and all 8 references in cpu_pd* nodes; renames cpu-sleep-1 to cpu-sleep-0

Verdict

Merge as-is. The patch is well-formed with proper commit message structure, clear rationale, appropriate tags (Reviewed-by, Link, Signed-off-by in correct order), and a clean diff that matches the stated intent.

Final Summary

Lore link present: Yes — Link tag points to patch.msgid.link/20260522-ml_cpuidle-v1-2-fd311cf33fb4@oss.qualcomm.com (part of v1 series)

Lore link matches PR commits: Cannot verify — network access restricted; unable to fetch upstream patch for byte-level comparison

Upstream patch status: In review — Message-ID format indicates v1 submission dated May 22, 2026; appears to be under review on mailing list

PR present in qcom-next: Not checked — no kernel tree access per constraints

Additional observations:

Commit message follows kernel DTS subsystem conventions

Tag ordering is correct: Reviewed-by → Link → Signed-off-by

Diff is clean: removes 11-line idle state definition, renames label on 1 line, updates 8 domain-idle-states properties

Rationale aligns with similar changes in SM8350/SM8450/SM8550/SM8650 (mentioned in commit body)

No trailing whitespace or formatting issues detected

Author email uses oss.qualcomm.com domain (appropriate for upstream submission)

qlijarvis · 2026-06-05T12:06:34Z

PR #1320 — checker-log-analyzer

PR: #1320
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27012126959

Checker	Result	Summary
Checker	Result	Summary
checkpatch	⏭️	Skipped - automerge failed
dt-binding-check	⏭️	Skipped - automerge failed
dtb-check	⏭️	Skipped - automerge failed
sparse-check	⏭️	Skipped - automerge failed
check-uapi-headers	⏭️	Skipped - automerge failed
check-patch-compliance	⏭️	Skipped - automerge failed
tag-check	N/A	Not applicable for this branch
qcom-next-check	N/A	Not applicable for this branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1320 - arm64: dts: qcom: lemans: Remove the gold_cpu_sleep idle state
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27012126959

Checker Result Summary

checkpatch ⏭️ Skipped - automerge failed

dt-binding-check ⏭️ Skipped - automerge failed

dtb-check ⏭️ Skipped - automerge failed

sparse-check ⏭️ Skipped - automerge failed

check-uapi-headers ⏭️ Skipped - automerge failed

check-patch-compliance ⏭️ Skipped - automerge failed

tag-check N/A Not applicable for this branch

qcom-next-check N/A Not applicable for this branch

❌ Infrastructure Failure: Automerge Conflicts

Root cause: The CI workflow failed during the automerge/sync phase before any checkers could run. The base branch tech/all/dt/qcs9100 has merge conflicts with the latest baseline tag when attempting to create an integration branch.

Failure details:
2026-06-05T11:43:16.1244472Z Auto-merging .mailmap
2026-06-05T11:43:16.1244869Z Auto-merging MAINTAINERS
2026-06-05T11:43:16.1245193Z Auto-merging Makefile
2026-06-05T11:43:16.1245646Z CONFLICT (content): Merge conflict in Makefile
2026-06-05T11:43:16.1246107Z Auto-merging arch/arm64/boot/dts/qcom/Makefile
2026-06-05T11:43:16.1246571Z Auto-merging arch/arm64/boot/dts/qcom/lemans.dtsi
2026-06-05T11:43:16.1247010Z Auto-merging arch/x86/entry/entry.S
2026-06-05T11:43:16.1247387Z Auto-merging arch/x86/kernel/idt.c
2026-06-05T11:43:16.1247866Z CONFLICT (content): Merge conflict in arch/x86/kernel/idt.c
...
2026-06-05T11:43:16.1892661Z Automatic merge failed; fix conflicts and then commit the result.
2026-06-05T11:43:16.3054470Z Merge failed, manual merge
2026-06-05T11:43:16.5882380Z automerge returned non-zero; check logs for conflicts
Conflicting files:

Makefile

arch/x86/kernel/idt.c

block/blk-mq.c

drivers/bluetooth/btusb.c

drivers/cpufreq/amd-pstate-ut.c

drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c

net/bluetooth/l2cap_sock.c

net/vmw_vsock/virtio_transport_common.c

Analysis:
The PR itself (arch/arm64/boot/dts/qcom/lemans.dtsi) is not the source of conflicts. The conflicts are in unrelated files across the kernel tree, indicating that the base branch tech/all/dt/qcs9100 has diverged significantly from the latest baseline and needs to be rebased or the conflicts need to be resolved in the base branch itself.

Fix:
This is not a PR issue - it's a base branch maintenance issue. The PR author cannot fix this. The branch maintainer needs to:

Rebase tech/all/dt/qcs9100 onto the latest baseline tag (v7.1-rc6 per logs)

Resolve the merge conflicts in the 8 files listed above

Push the updated base branch

Re-trigger the checker workflow

Reproduce locally:
# Clone the kernel repo
git clone https://github.com/qualcomm-linux/kernel.git
cd kernel

# Fetch the base branch
git fetch origin tech/all/dt/qcs9100
git checkout tech/all/dt/qcs9100

# Attempt to merge with latest baseline
git fetch origin
git merge v7.1-rc6

# You will see the same 8 merge conflicts
ℹ️ PR Patch Quality

The PR patch itself appears clean:

Changes: Removes unused gold_cpu_sleep_0 idle state from lemans.dtsi

Scope: Single devicetree file modification

Style: Follows kernel DT conventions

Metadata: Has proper Reviewed-by and Link tags

Commit message: Clear rationale provided

Since the checkers never ran, we cannot verify:

Checkpatch compliance

DT binding schema validation

DTB compilation

Sparse warnings

Verdict

Infrastructure failure - not a PR blocker. The PR cannot be evaluated because the base branch has merge conflicts with the baseline. The base branch maintainer must resolve conflicts in tech/all/dt/qcs9100 before this PR can be properly validated. Once the base branch is fixed, re-run the checkers to validate the PR patch itself.

maulik-k-shah

Looks good to me.

maulik-k-shah · 2026-06-08T07:17:52Z

FROMLIST: tag missing

qcomlnxci requested review from a team, idlethread, knaveen-qc and quicAspratap and removed request for a team June 5, 2026 11:26

maulik-k-shah approved these changes Jun 8, 2026

View reviewed changes

maulik-k-shah reviewed Jun 8, 2026

View reviewed changes

Comment thread arch/arm64/boot/dts/qcom/lemans.dtsi

maulik-k-shah Jun 8, 2026

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FROMLIST: tag missing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lemans: Remove the gold_cpu_sleep idle state#1320

lemans: Remove the gold_cpu_sleep idle state#1320
navya-malempati wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs9100from
navya-malempati:qcs9100

navya-malempati commented Jun 5, 2026

Uh oh!

qlijarvis commented Jun 5, 2026

Uh oh!

qlijarvis commented Jun 5, 2026

Uh oh!

qlijarvis commented Jun 5, 2026

🔍 Patch Validation

Commit Message

Diff

Verdict

Final Summary

Uh oh!

qlijarvis commented Jun 5, 2026

🤖 CI Checker Analysis (checker-log-analyzer)

❌ Infrastructure Failure: Automerge Conflicts

ℹ️ PR Patch Quality

Verdict

Uh oh!

maulik-k-shah left a comment

Uh oh!

maulik-k-shah Jun 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

navya-malempati commented Jun 5, 2026

Uh oh!

qlijarvis commented Jun 5, 2026

🔨 Build Failure Analysis — PR #1320

Verdict

Uh oh!

qlijarvis commented Jun 5, 2026

🔨 Build Failure Analysis — PR #1320

Verdict

Uh oh!

qlijarvis commented Jun 5, 2026

PR #1320 — validate-patch

Final Summary

🔍 Patch Validation

Commit Message

Diff

Verdict

Final Summary

Uh oh!

qlijarvis commented Jun 5, 2026

PR #1320 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ Infrastructure Failure: Automerge Conflicts

ℹ️ PR Patch Quality

Verdict

Uh oh!

maulik-k-shah left a comment

Choose a reason for hiding this comment

Uh oh!

maulik-k-shah Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants