feat(sandbox): support injection match conditions#467
Conversation
Add if_headers and if_queries normalization for sandbox injection requests, update the example flow, and cover the new request shapes in tests. Also handle envd status-based command exit codes observed during integration validation.
There was a problem hiding this comment.
Code Review
This pull request introduces support for if_headers and if_queries condition matching fields in Sandbox injection rules, along with camelCase compatibility. It also enhances command exit code parsing to handle snake_case keys and status strings. Additionally, test coverage is improved by isolating environment variables, verifying parameter normalization, and handling unsupported runtime errors in integration tests. No review comments were provided, and the implementation is clean and well-tested.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
No issues found in this review. I reviewed the PR diff across code quality, performance, security, and documentation accuracy.
Verification: git diff --check origin/master...HEAD passed. Targeted pytest could not be run because pytest is not installed in this environment.
Summary
ifHeaders/ifQueries->if_headers/if_queries)base_url,if_headers, andif_queriesstatus: "exit status N"instead ofexitCodeValidation
pytest tests/cases/test_services/test_sandbox(120 passed, 3 skipped)python examples/sandbox_injection_rules.py(create/get/update/delete succeeded against the configured sandbox endpoint)