Switch CPPCHECK to broad coverage with excludes#19909
Open
perheld wants to merge 6 commits into
Open
Conversation
perheld
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19909
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 313 PendingAs of commit ef871de with merge base eeb0646 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the lintrunner CPPCHECK linter configuration to lint all C/C++ sources by default and rely on an explicit, commented exclude_patterns list to control scope (so newly added files are picked up unless explicitly excluded).
Changes:
- Broadened
CPPCHECKinclude_patternsfrom a few backend/example subtrees to**/*.cpp,**/*.h,**/*.hpp. - Added a large, categorized
exclude_patternslist to keep cppcheck off vendored/generated areas and components not yet onboarded.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mergennachin
approved these changes
Jun 1, 2026
Switch lintrunner cppcheck include pattern to include all files and rely on the exclude pattern to not lint files. This has the positive side effect that new files would be included in the linting and the exclude list can have a nice sorting and comments why things have ended up there. The end goal should of course be a empty exclude_patterns list. Signed-off-by: Per Held <per.held@arm.com> Change-Id: Id815fcbf7a6ba901b6d1b1ace4209ff157a15d7e
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch lintrunner cppcheck include pattern to include all files and rely on the exclude pattern to not lint files.
This has the positive side effect that new files would be included in the linting and the exclude list can have a nice sorting and comments why things have ended up there.
The end goal should of course be a empty exclude_patterns list.
Change-Id: Id815fcbf7a6ba901b6d1b1ace4209ff157a15d7e
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani