Remove questionable dataclass descriptor conformance assertions#2296
Open
BHUVANSH855 wants to merge 2 commits into
Open
Remove questionable dataclass descriptor conformance assertions#2296BHUVANSH855 wants to merge 2 commits into
BHUVANSH855 wants to merge 2 commits into
Conversation
BHUVANSH855
force-pushed
the
fix-2259-dataclass-descriptor-tests
branch
from
aee0e78 to
15e4fe0
Compare
BHUVANSH855
force-pushed
the
fix-2259-dataclass-descriptor-tests
branch
from
15e4fe0 to
c48ab35
Compare
BHUVANSH855
force-pushed
the
fix-2259-dataclass-descriptor-tests
branch
from
09c8961 to
d6caba9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove questionable
Desc2conformance assertions fromdataclasses_descriptors.py.The existing assertions do not align with actual runtime behavior for non-data descriptors in dataclasses:
DC2.xandDC2.yraiseAttributeErrorat runtime because no descriptor instance exists in the class dictionary for those fields.dc2.xanddc2.yevaluate to the storedDesc2instances because non-data descriptors are shadowed by instance attributes.zcase is also subtle due to descriptor access during dataclass default extraction.Since this behavior is currently under-specified and differs across type checkers and runtime semantics, this PR removes the questionable assertions and replaces them with explanatory comments.
Fixes #2259