Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/semanal.py
Original file line number Diff line number Diff line change
Expand Up @@ -6432,7 +6432,7 @@ def analyze_comp_for(self, expr: GeneratorExpr | DictionaryComprehension) -> Non
if i > 0:
sequence.accept(self)
# Bind index variables.
self.analyze_lvalue(index)
self.analyze_lvalue(index, is_index_var=True)
for cond in conditions:
cond.accept(self)

Expand Down
11 changes: 11 additions & 0 deletions test-data/unit/check-typeddict.test
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,17 @@ def get_coordinate(p: TaggedPoint, key: str) -> Union[str, int]:
[builtins fixtures/dict.pyi]
[typing fixtures/typing-typeddict.pyi]

[case testCanGetItemOfTypedDictWithStringLiteralKeyInComprehension]
from typing import TypedDict
Data = TypedDict('Data', {'field1': int, 'field2': str, 'field3': str})
data: Data
def is_str(value: object) -> bool: ...
filtered_keys1 = [data[key] for key in ("field1", "field2", "field3")]
filtered_keys2 = [key for key in ("field1", "field2", "field3") if is_str(data[key])]
reveal_type(filtered_keys1) # N: Revealed type is "builtins.list[builtins.int | builtins.str]"
reveal_type(filtered_keys2) # N: Revealed type is "builtins.list[builtins.str]"
[builtins fixtures/for.pyi]
[typing fixtures/typing-full.pyi]

-- Special Method: __setitem__

Expand Down
Loading